Skip to content

fix(versionsource): "delegate" permission check to api #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auniverseaway merged 1 commit into from
Oct 3, 2025
Merged

fix(versionsource): "delegate" permission check to api #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export async function getAclCtx(env, org, users, key, api) {
// Expose the action trace or not?
actionTrace = users.every((u) => aclTrace.includes(u.email)) ? actionTrace : undefined;

if (k === 'CONFIG') {
if (k === 'CONFIG' || api === 'versionsource') {
actionSet.add('read');
}

Expand Down
15 changes: 14 additions & 1 deletion test/utils/auth.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,20 @@ describe('DA auth', () => {
const users = [{email: "blah@foo.org"}];
const aclCtx = await getAclCtx(env2, 'test', users, '/', 'config');
assert(aclCtx.actionSet.has('read'));
})
});

it('test versionsource api always has read permission', async () => {
const users = [{email: "blah@foo.org"}];
const aclCtx = await getAclCtx(env2, 'test', users, '/', 'versionsource');
assert(aclCtx.actionSet.has('read'));
});

it('test versionsource api grants read permission even without explicit permissions', async () => {
const users = [{email: "unauthorized@example.com"}];
const aclCtx = await getAclCtx(env2, 'test', users, '/restricted', 'versionsource');
assert(aclCtx.actionSet.has('read'));
assert(!aclCtx.actionSet.has('write'));
});
});

describe('persmissions single sheet', () => {
Expand Down