Skip to content

chore: fix tests to match production#171

Merged
auniverseaway merged 1 commit into
mainfrom
fixlist
Sep 4, 2025
Merged

chore: fix tests to match production#171
auniverseaway merged 1 commit into
mainfrom
fixlist

Conversation

@auniverseaway

Copy link
Copy Markdown
Member
  • List now matches the other functions that forcefully remove the key
  • Org is handled outside of the key, made mocks match reality

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Org is handled outside of the key, made mocks match reality
@codecov

codecov Bot commented Sep 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@auniverseaway

Copy link
Copy Markdown
Member Author

I'm not in love with this, but it matches how we're doing it today and we need to get back to auto deployments. Once this is merged, we can turn on auto deployments again.

Also: now that we're relatively stable on the new infra, we can clean up some of this bucket / org / key removal stuff.

@auniverseaway
auniverseaway merged commit 4ee25dd into main Sep 4, 2025
4 checks passed
@auniverseaway
auniverseaway deleted the fixlist branch September 4, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants