Skip to content

Sync infra to main#164

Merged
auniverseaway merged 13 commits into
mainfrom
infra
Aug 27, 2025
Merged

Sync infra to main#164
auniverseaway merged 13 commits into
mainfrom
infra

Conversation

@auniverseaway

Copy link
Copy Markdown
Member

This will put the infra branch onto main.

@kptdobe

kptdobe commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

I fixed the GET test (bucket was missing).

For the remaining failing tests, I think the problem is coming from the code, not from the tests: the org is removed from the key... I do not think this makes sense: https://github.com/adobe/da-admin/pull/164/files#diff-1e28f1f17222ebe544a6c1fed5203cd46559ee608f970d8fc6ed47f09f79b08fR109 (same for the move https://github.com/adobe/da-admin/pull/164/files#diff-cb39c1049fbd75155ee3c3bf0b08d196b7470d37c89d0fdb31166e6a3bb7e1bdR51).

@bosschaert @auniverseaway WDYT?

@auniverseaway

Copy link
Copy Markdown
Member Author

@kptdobe thanks! I'll take a look.

@codecov

codecov Bot commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.02985% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/storage/version/list.js 25.00% 3 Missing ⚠️
src/storage/version/get.js 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@auniverseaway
auniverseaway merged commit 6ad7012 into main Aug 27, 2025
4 checks passed
@auniverseaway
auniverseaway deleted the infra branch August 27, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants