Skip to content

fix: versioning timestamp for version and document itself #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auniverseaway merged 2 commits into from
Jun 25, 2025
Merged

fix: versioning timestamp for version and document itself #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d591255
fix: versioning timestamp for version and document itself
mhaack Jun 24, 2025
0250a2e
Merge branch 'main' into veriontime
mhaack Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/storage/version/put.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export async function putObjectWithVersion(env, daCtx, update, body, guid) {
Ext: daCtx.ext,
Metadata: {
Users: current.metadata?.users || JSON.stringify([{ email: 'anonymous' }]),
Timestamp: current.metadata?.timestamp || Timestamp,
Timestamp,
Path: current.metadata?.path || Path,
Label,
},
Expand All @@ -134,7 +134,12 @@ export async function putObjectWithVersion(env, daCtx, update, body, guid) {
const command = new PutObjectCommand({
...input,
Metadata: {
ID, Version: crypto.randomUUID(), Users, Timestamp, Path, Preparsingstore,
ID,
Version: crypto.randomUUID(),
Users,
Timestamp: current.metadata?.timestamp || Timestamp,
Path,
Preparsingstore,
},
});
try {
Expand Down
8 changes: 5 additions & 3 deletions test/storage/version/put.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ describe('Version Put', () => {
metadata: {
id: 'x123',
version: 'aaa-bbb',
timestamp: 1750765279755,
},
status: 200
};
Expand Down Expand Up @@ -201,7 +202,7 @@ describe('Version Put', () => {
assert.equal('x123', s3Sent[0].input.Metadata.ID);
assert.equal('/a/x.html', s3Sent[0].input.Metadata.Path);
assert.notEqual('aaa-bbb', s3Sent[0].input.Metadata.Version);
assert(s3Sent[0].input.Metadata.Timestamp > 0);
assert.strictEqual(1750765279755, s3Sent[0].input.Metadata.Timestamp);
});

it('Put Object With Version don\'t store content', async () => {
Expand Down Expand Up @@ -498,8 +499,8 @@ describe('Version Put', () => {
assert.equal('', input.Body, 'Empty body for HEAD');
assert.equal(0, input.ContentLength, 'Should have used 0 as content length for HEAD');
assert.equal('/q', input.Metadata.Path);
assert.equal(123, input.Metadata.Timestamp);
assert.equal('[{"email":"anonymous"}]', input.Metadata.Users);
assert(input.Metadata.Timestamp > 0);
});

it('Test putObjectWithVersion BODY', async () => {
Expand Down Expand Up @@ -563,8 +564,8 @@ describe('Version Put', () => {
assert.equal('Somebody...', input.Body);
assert.equal(616, input.ContentLength);
assert.equal('/qwerty', input.Metadata.Path);
assert.equal(1234, input.Metadata.Timestamp);
assert.equal('[{"email":"anonymous"}]', input.Metadata.Users);
assert(input.Metadata.Timestamp > 0);

assert.equal(1, sentToS3_2.length);
const input2 = sentToS3_2[0].input;
Expand All @@ -574,6 +575,7 @@ describe('Version Put', () => {
assert.equal('/mypath', input2.Key);
assert.equal('/mypath', input2.Metadata.Path);
assert.equal('[{"email":"hi@acme.com"}]', input2.Metadata.Users);
assert.strictEqual(1234, input2.Metadata.Timestamp);
assert(input2.Metadata.Version && input2.Metadata.Version !== 101);
});
});