Skip to content

Single Bucket using S3 APIs#140

Closed
bosschaert wants to merge 5 commits into
mainfrom
s3sb3
Closed

Single Bucket using S3 APIs#140
bosschaert wants to merge 5 commits into
mainfrom
s3sb3

Conversation

@bosschaert

@bosschaert bosschaert commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Description

This PR combines all the changes for S3-based single-bucket into one branch.

Note that merging this PR will change the storage structure on S3/R2, so be sure to migrate the data!

Related Issue

Fixes: #113

How Has This Been Tested?

  • Unit tests
  • Locally with da-collab and da-live
  • Integration tests from @bstopp here 3e06eae

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Co-authored-by: @bstopp
Co-authored-by: Bryan Stopp bryan.stopp@gmail.com
Co-authored-by: @auniverseaway
Co-authored-by: Chris Millar cmillar@adobe.com

@bosschaert
bosschaert requested a review from karlpauls June 16, 2025 15:05
@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (a73a36e) to head (5fe3445).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/object/get.js 20.00% 4 Missing ⚠️
src/utils/auth.js 33.33% 4 Missing ⚠️
src/storage/version/list.js 25.00% 3 Missing ⚠️
src/storage/utils/list.js 87.50% 1 Missing ⚠️
src/storage/version/get.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   75.74%   75.94%   +0.20%     
==========================================
  Files          39       39              
  Lines        2255     2216      -39     
==========================================
- Hits         1708     1683      -25     
+ Misses        547      533      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bosschaert
bosschaert requested a review from auniverseaway June 16, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single Bucket

2 participants