Skip to content

feat: add support for detached cmds#3

Merged
MichaelGoberling merged 6 commits into
mainfrom
detached-cmds
Jun 2, 2026
Merged

feat: add support for detached cmds#3
MichaelGoberling merged 6 commits into
mainfrom
detached-cmds

Conversation

@MichaelGoberling
Copy link
Copy Markdown
Collaborator

Ticket: https://jira.corp.adobe.com/browse/ACNA-4637

  • Add support for running commands in the background, via detached: true option
  • Add support for a new getCommand(execId) for "re-attaching" to a running background command
  • Add support for cleanly closing the websocket connection on sandbox destroy, so there are no errors when users destroy sandboxes

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same nit: if the server sends exec.exit before the exec.detached ack, the detached path mishandles it

(JS: wait() hangs; Python: raw TypeError on result["pid"])

@MichaelGoberling MichaelGoberling merged commit a044cc0 into main Jun 2, 2026
6 checks passed
@MichaelGoberling MichaelGoberling deleted the detached-cmds branch June 2, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants