JSON Validation to fluent builder pattern#1194
Open
timkimadobe wants to merge 30 commits into
Open
Conversation
…tion inheritance bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
m4pro.medium)AEPCore/Tests/FunctionalTests/Configuration/ConfigurationAppIDTests.swiftXCTAssertEqual(mockRuntime.firstSharedState?.toAnyCodable(), mockRuntime.secondSharedState?.toAnyCodable())to use JSON validation insteadAnyCodableAsserts)Before
After
It consolidates the assertion API into a single entry point with the following default validation configurations:
actualcan contain more keys/elements thanexpected(subset match).Important
This is a breaking change for the older JSON validation APIs, since the
MultiPathConfigused to configure options has been replaced with the newJSONPathand builder APIs.However, migration instructions have been included in the new doc: Documentation/Testing/JSONValidation.md (useful for devs and agents)
It also includes:
Additional context
MultiPathConfigAnyOrderMatch.anyOrder(at: ...)CollectionEqualCount.equalCount(at: ...)ElementCount.elementCount(count, at: ...)KeyMustBeAbsent.keyMustBeAbsent(at: ...)ValueNotEqual.valueNotEqual(at: ...)ValueExactMatch.exactMatch(at: ...)ValueTypeMatch.typeMatch(at: ...)Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: