Skip to content

feat: surface per-component conversion warnings in job results UI #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
im-shiv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: surface per-component conversion warnings in job results UI #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a00b42a
feat: surface per-component conversion warnings in job results UI
May 13, 2026
cd3f49f
fix: revert shared navpanel.html — dynamic loop works for all job types
May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion core/src/main/java/com/adobe/aem/modernize/job/datasource/ConversionJobBucketDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
*/

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -99,6 +101,7 @@ protected void doGet(@NotNull SlingHttpServletRequest request, @NotNull SlingHtt
}

private DataSource buildDataSource(final ResourceResolver rr, final ConversionJobBucket bucket, int offset, int limit) {
Map<String, List<String>> warningsByPath = parseWarnings(bucket);
List<Resource> entries = bucket.getPaths().stream().skip(offset).limit(limit).map(p -> {
Map<String, Object> vm = new HashMap<>();
vm.put("path", p);
Expand All @@ -118,10 +121,31 @@ private DataSource buildDataSource(final ResourceResolver rr, final ConversionJo
vm.put("status", "Unknown");
vm.put("statusClass", "unknown");
vm.put("icon", "helpCircle");

}
List<String> warns = warningsByPath.getOrDefault(p, Collections.emptyList());
if (!warns.isEmpty()) {
vm.put("warnings", true);
vm.put("warningList", warns.toArray(new String[0]));
}
return new ValueMapResource(rr, p, ITEM_RESOURCE_TYPE, new ValueMapDecorator(vm));
}).collect(Collectors.toList());
return new SimpleDataSource(entries.iterator());
}

private Map<String, List<String>> parseWarnings(ConversionJobBucket bucket) {
String[] raw = bucket.getResource().getValueMap().get("warnings", new String[0]);
if (raw.length == 0) {
return Collections.emptyMap();
}
Map<String, List<String>> result = new HashMap<>();
for (String entry : raw) {
int sep = entry.indexOf("||");
if (sep > 0) {
String path = entry.substring(0, sep);
String msg = entry.substring(sep + 2);
result.computeIfAbsent(path, k -> new ArrayList<>()).add(msg);
}
}
return result;
}
}
9 changes: 8 additions & 1 deletion ui.apps/src/main/content/jcr_root/apps/aem-modernize/components/job/bucket/item/item.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@
#L%
-->
<tr is="coral-table-row" title="${properties.path}" class="foundation-collection-item">
<td is="coral-table-cell">${properties.path}</td>
<td is="coral-table-cell">
<div>${properties.path}</div>
<sly data-sly-test="${properties.warnings}">
<sly data-sly-list.warning="${properties.warningList}">
<div style="font-size:11px;color:#d7373f;margin-top:2px;">&#x26A0; ${warning}</div>
</sly>
</sly>
</td>
<td is="coral-table-cell" value="${properties.status}">${properties.status}</td>
<td is="coral-table-cell">
<div class="mediumIcon ${properties.statusClass}">
Expand Down