SITES-16562 - [Xwalk] Open Universal Editor from Franklin Sidekick#1
Open
jckautzmann wants to merge 1 commit into
Open
SITES-16562 - [Xwalk] Open Universal Editor from Franklin Sidekick#1jckautzmann wants to merge 1 commit into
jckautzmann wants to merge 1 commit into
Conversation
- edit the page with the AEM editor
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
buuhuu
reviewed
Nov 2, 2023
| async function overrideEditButton(sk) { | ||
| const oldEditBtn = await getButton(sk, '.edit.plugin'); | ||
| const newEditBtn = await getButton(sk, '.aemedit.plugin'); | ||
| oldEditBtn.replaceWith(newEditBtn); |
Collaborator
There was a problem hiding this comment.
why do we need a new button actually? can we get the old button and just replace the click behaviour?
If so we would not need to add any sidekick config.
Author
There was a problem hiding this comment.
I tried it but it didn't work because:
- the Edit button is disabled
- even if we enable it, the ootb logic is triggered when the button is clicked and it cannot be overridden
buuhuu
pushed a commit
that referenced
this pull request
Jan 31, 2024
be2e07d doc: update README.md 287e35f feat: adopt the plugin api (#2) 9028520 fix: possible css leaking into pill overlay 162aab2 fix: improve anonymization for better gdpr/hippa compliance (#3) 0071dbd fix: audience pill activation a486023 fix: audience parsing 4789afd feat: limit the sampling rate 7fbef36 feat: limit the sampling rate (#1) 92e2abb fix: campaigns parsing 4467d3e fix: block-level experiments resolution 4438f52 doc: update readme 44a3aa4 fix: support installation in sub-directories a77433f style: properly inherit text color in the overlay git-subtree-dir: plugins/experience-decisioning git-subtree-split: be2e07ddce1d9c8d1622e6221f7a16593d87b811
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs:
Before: https://main--wknd-xwalk--adobe-rnd.hlx.page/us/en
After: https://SITES-16562-open-editor--wknd-xwalk--adobe-rnd.hlx.page/us/en