Show filesize

[gngn23]

No description provided.

[gngn23]

Show file size, as discussed in #26

[gngn23]

I also added some basic error check in case filesize() returns FALSE.

[gngn23]

@adixon can I do anything about this ticket?

[adixon]

@adixon can I do anything about this ticket?

Yes, there's a comment in there, I think you're running the risk of trying to evaluate log(0), which isn't pretty.

[gngn23]

I do not see a comment, but I think you mean

  protected function readableBytes(int|string $bytes): string {
    $i = floor(log($bytes) / log(1024));
    $sizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
    return sprintf('%.02F', $bytes / pow(1024, $i)) * 1 . ' ' . $sizes[$i];

And you're right, I should check if $bytes is 0.

I am going to fix this.

[gngn23]

@adixon : I am now checking zero or negative number of bytes.
I also changed function readableBytes() to only accept int (and fixed an unrelated typo).

What do you think?

[adixon]

That works!