fix: version 15

docs/09-2025.md

@@ -0,0 +1,122 @@
+# Migration Notes: V12 → V16
+
+## Skipped Steps
+- Skipped unnecessary patches (see **before_migrate_patches.py**).  
+- Reference: [Patch List Spreadsheet](https://docs.google.com/spreadsheets/d/1TUkAwRF6NhEAzFjcM6WAPyT6dEdREkuDl5sANb-eK4o/edit?pli=1&gid=1625746251#gid=1625746251)
+
+---
+
+## Fixed & Pending Issues
+
+### 1. Sales Invoice (Save Failure + E-Invoice)
+**Status:** ✅ Resolved  
+
+- **Root Cause:** Custom code resetting *Place of Supply* caused save failures.  
+  - **File:** `validations/sales_invoice.py`  
+  - **Method:** `check_local_natl_tax_rules()`
+- **Fix:** Removed the faulty custom code.
+- **E-Invoice:** Re-enabled via **India Compliance**.  
+  - Requires re-setup for new sites.  
+  - Path: **GST Settings → Enable E-Invoice** (currently in sandbox mode).  
+  - Setup Guide: [India Compliance Docs](https://docs.indiacompliance.app/docs/ewaybill-and-einvoice/gst_settings)
+- **Print Format:** Created new print format — **RIGPL IC e-Invoice** — which excludes QR Code, Ack No, and Ack Date.
+
+---
+
+### 2. File List (Search Issues)
+**Issue:** File names attached to Doctypes were not searchable.  
+**Fix:** Corrected hook path and method override.  
+- **Hook:** `override_whitelisted_methods`  
+- **Method:** `rohit_common.core.file.get_files_by_search_text`
+
+---
+
+### 3. File List (Permission Issues)
+**Issue:** *System Manager* could not view files not attached to any Doctype.  
+**Root Cause:** Frappe’s `has_permission` hooks run in reverse order, causing our hook to execute before Frappe’s own.  
+**Fix:** Overrode Frappe’s `File` methods to ensure proper permission evaluation.  
+- **Reference:** [frappe/permissions.py#L467](https://github.com/frappe/frappe/blob/develop/frappe/permissions.py#L467)  
+- **Custom Code:**  
+  - `overrides/file.py`  
+  - `hooks/__init__.py`
+
+---
+
+### 4. GST Return Status
+**Status:** ✅ Fixed  
+**Issue:** Unable to fetch GST Return Status.  
+**Fix:** Integrated **India Compliance API** for fetching GST return data.
+
+---
+
+### 5. Address (GST Validation)
+**Status:** ✅ Fixed  
+**Issue:** GST API validation not working.  
+**Fix:** Switched to **India Compliance API** for validation.
+
+---
+
+### 6. General Ledger Report
+**Issue:** The standard General Ledger displayed detailed opening balances instead of a net opening.  
+**Fix:** Created a custom report — **RIGPL General Ledger** — which shows only net opening balances.
+
+---
+
+### 7. Asset (Customizations)
+**Status:** ✅ Fix deployed.
+
+---
+
+### 8. Asset Report (Analysis)
+**Status:** ✅ Fix deployed.
+
+---
+
+### 9. Contact (Search Fields)
+**Issue:** Search did not work based on fields defined in **Customize Form**.  
+**Findings:** The method `rohit_common.utils.contact_utils.rigpl_contact_query` exists but is not used anywhere.  
+**Status:** ⚙️ Pending review / refactor.
+
+---
+
+### 10. Pricing Rule
+**Issue:** Sales Orders not fetching rules for *Item Group* children (worked in V12).  
+**Action:** Skipped — not related to this app.
+
+---
+
+### 11. Asset Patch Failure
+**Status:** ✅ Fixed  
+**Fix:** Patch execution issue resolved.
+
+---
+
+### 12. Sales Invoice (E-Invoice JSON)
+**Issue:** E-Invoice JSON should send only item summaries, not line-wise rates.  
+**Status:** ⚠️ Limitation  
+- Quantity and Unit Price fields are mandatory per **India Compliance API** specifications, so they cannot be removed.
+
+---
+
+### 13 & 14. Accounts Receivable (AR) Report
+**Issue:** Payment Ledger was empty due to a skipped patch introduced in later versions.  
+**Fix:** Added a script to backfill Payment Ledger entries.  
+
+- **File:** `rohit_common/rohit_common/migration_scripts/migrate_gl_to_payment_ledger.py`  
+- **Method:** `migrate_gl_to_payment_ledger()`
+
+**Notes:**  
+- The official Frappe ERPNext patch will run automatically.  
+- If it fails to populate the Payment Ledger, run the above script manually.  
+- Ensure **all Fiscal Years are enabled** before running the script.
+
+---
+
+## ✅ Overall Migration Summary
+- Core modules are functional.  
+- India Compliance integrations (E-Invoice, GST Validation, Return Status) are fully operational.  
+- Custom reports and patches applied successfully.  
+- All critical migration issues resolved or documented for follow-up.
+
+**Last Updated:** _October 2025_  
+**Maintained By:** Development Team

docs/10-2025.md

@@ -0,0 +1,198 @@
+# New Issues Log: Post Migration (After #14)
+
+This document lists additional issues reported after the initial migration testing phase.  
+Format and structure follow the main migration notes for consistency.
+
+---
+
+### 15. Sales Invoice (Multiple Save & UI Issues)
+**Status:** ✅ Resolved  
+
+**Issues Identified:**  
+1. Ship-to Address not auto-fetching and search not available.  
+2. Customer Purchase Order not editable.  
+3. “Total Amount (In Words)” missing in PDF/Print.  
+4. Letterhead missing in printed invoice.  
+5. Packing List, Export Invoice, and Custom Invoice not visible.  
+6. New interface more complex compared to old version.
+
+**Fix:**  
+- Ship-to Address now auto-fetches.  
+- Customer Purchase Order field made editable.  
+- Total Amount (In Words) now displays in print format.  
+- Letterhead added to PDF/Print.  
+- All required print formats are now available.
+
+---
+
+### 16. Sales Invoice (Errors While Creating Invoices)
+**Status:** ⚙️ Under Review  
+
+**Issues Identified:**  
+1. “No permission for Accounts Settings.”  
+2. Customer PO details were under *More Info* instead of *Details*.  
+3. CETSH Code (82078000) missing for certain items.  
+4. Only Domestic Invoice format available.
+
+**Fix / Developer Notes:**  
+- Verified System Manager permissions.  
+- Moved PO details to the **Details** tab.  
+- Confirmed HSN Code presence.  
+- Other print formats are available for export invoices.
+
+---
+
+### 17. Purchase Invoice (Unable to Save)
+**Status:** ✅ Fixed  
+
+**Issue:**  
+Validation error — *“Please set Account in Warehouse Machinery or Default Inventory Account in Company.”*
+
+**Fix:**  
+- Created and linked **Stock Account** in Warehouse and Company settings.  
+- Verified GL posting.  
+- Reference: [Default Warehouse](http://51.15.187.192:8000/app/warehouse/Default%20Warehouse)
+
+---
+
+### 18. Journal Entry (Letterhead Missing)
+**Status:** ✅ Fixed  
+**Issue:** Letterhead not appearing in PDF or print.  
+**Fix:** Letterhead template verified and restored.
+
+---
+
+### 19. Payment Entry (Letterhead Missing)
+**Status:** ✅ Fixed  
+**Issue:** Letterhead not appearing in PDF or print.  
+**Fix:** Verified and restored print format; working fine.
+
+---
+
+### 20. General Ledger (Performance & Print)
+**Status:** ⏳ Pending  
+
+**Issues:**  
+- Report takes longer to load.  
+- Print & PDF options missing.
+
+---
+
+### 21. Customer (Address Save Error)
+**Status:** ✅ Fixed  
+
+**Issues:**  
+1. State field not searchable.  
+2. Error while saving address: `ModuleNotFoundError: No module named 'responses'` (India Compliance).
+
+**Fix:**  
+- Fixed search filter for State field.  
+- Added missing India Compliance dependency.
+
+---
+
+### 22. Supplier (Address Save Error)
+**Status:** ✅ Fixed  
+
+**Issues:**  
+1. State field not searchable.  
+2. Error while saving address: `ModuleNotFoundError: No module named 'responses'`.
+
+**Fix:**  
+- Same fix as Customer: State search and dependency added.
+
+---
+
+### 23. Payment Period Based on Invoice Date (Incorrect Data)
+**Status:** ⚙️ To Check  
+**Issue:** *Payment Posting Date* column missing, causing inaccurate delay calculation.  
+**Action:** Verify report field mapping and correct data source.
+
+---
+
+### 24. GSTR2A (Permission Error)
+**Status:** ⚙️ To Check  
+**Issue:** “You are not permitted to access this resource. Login to access.”  
+**Fix / Notes:** Updated user permissions; awaiting confirmation.
+
+---
+
+### 25. GSTR1 (Permission & API Error)
+**Status:** ⚙️ To Check  
+
+**Issues:**  
+- Same “not permitted” access issue.  
+- API configuration error from India Compliance.
+
+**Action:**  
+- Permissions updated.  
+- API setup Needs to be verified.
+
+---
+
+### 26. Trial Balance (Incorrect Data)
+**Status:** 🟡 Pending  
+**Issue:** Data mismatch for April 2025 onwards — incorrect AR/AP/Duties and Taxes.  
+**Action:** Awaiting sample data from accounting team for verification.
+
+---
+
+### 27. ClearTax Import Format (Background Report)
+**Status:** ℹ️ Info  
+**Issue:** “This is a background report. Please set filters before generating.”  
+
+---
+
+### 28. Profit & Loss Statement (Incorrect Monthly Totals)
+**Status:** 🟡 Pending  
+**Issue:** Totals for May include April+May, cascading for later months.  
+**Action:** Require sample dataset for validation.
+
+---
+
+### 29. Balance Sheet (Incorrect Data)
+**Status:** 🟡 Pending  
+**Issue:** AR/AP/Reserves/Duties and Taxes not displaying correctly for Apr 2025.  
+**Action:** Awaiting sample data for reconciliation testing.
+
+---
+
+### 30. Asset Depreciations & Balances (Incorrect Values)
+**Status:** 🟡 Pending  
+**Issue:** Incorrect depreciation for *Four Wheelers - Cars (Apr 2024 to Mar 2025)*.  
+**Action:** Cross-verify values with GL Report.
+
+---
+
+### 31. Payment Ledger Entry (Incorrect Voucher Type)
+**Status:** ⚙️ To Check  
+**Priority:** 🔴 Urgent  
+
+**Issue:**  
+- Wrong Voucher Type displayed.  
+- Missing ledger entries for vendor payments.
+
+**Fix:** Added a script to backfill Payment Ledger entries.  
+
+- **File:** `rohit_common/rohit_common/migration_scripts/migrate_gl_to_payment_ledger.py`  
+- **Method:** `migrate_gl_to_payment_ledger()`
+
+**Notes:**  
+- The official Frappe ERPNext patch will run automatically.  
+- If it fails to populate the Payment Ledger, run the above script manually.  
+- Ensure **all Fiscal Years are enabled** before running the script.
+
+---
+
+### 32. Sales Invoice (India Compliance for Old Transactions)
+**Status:** ⏳ Pending  
+**Priority:** 🔴 Urgent  
+
+**Issue:**  
+India Compliance setup not working for older Sales & Purchase transactions.
+
+
+---
+
+**Last Updated:** _October 2025_  
+**Maintained By:** Development Team

pyproject.toml

@@ -9,5 +9,5 @@ dynamic = ["version"]
 dependencies = [
     # Core dependencies
     "phonenumbers==8.13.13",
-    "india-compliance @ git+https://github.com/resilient-tech/india-compliance.git#version-15",
+    "responses>=0.25.8",
 ]

rohit_common/__init__.py

@@ -1 +1,25 @@
 __version__ = "15.0.0"
+
+# Monkey-patch AssetDepreciationSchedule to add set_draft_asset_depr_schedule_details
+
+from erpnext.assets.doctype.asset_depreciation_schedule.asset_depreciation_schedule import AssetDepreciationSchedule
+import frappe
+from rohit_common.patches.asset_depr_schedule_patch_utils import set_draft_asset_depr_schedule_details
+AssetDepreciationSchedule.set_draft_asset_depr_schedule_details = set_draft_asset_depr_schedule_details
+
+# Monkey-patched File to allow System Manager to access all files
+
+from rohit_common.overrides.file import get_permission_query_conditions,has_permission
+frappe.frappe.core.doctype.file.file.has_permission=has_permission
+frappe.frappe.core.doctype.file.file.get_permission_query_conditions=get_permission_query_conditions
+
+
+import frappe.contacts.doctype.contact.contact as original_contact_module
+from rohit_common.core.contact import custom_contact_query
+original_contact_module.contact_query = custom_contact_query
+
+
+# Override for EInvoiceData.get_data
+# from india_compliance.gst_india.utils.e_invoice import EInvoiceData
+# from rohit_common.overrides.india_compliance_einvoice import custom_get_data
+# EInvoiceData.get_data = custom_get_data

rohit_common/api.py

@@ -0,0 +1,6 @@
+import frappe
+
+@frappe.whitelist()
+def get_accounts_settings_value(fieldname):
+    # Ignore permissions to allow fetching this value from Accounts Settings directly
+    return frappe.db.get_single_value("Accounts Settings", fieldname)