Skip to content

Implement dynamic weather emoji based on conditions#69

Open
Shreyya-ux wants to merge 6 commits into
aditya-ai00:mainfrom
Shreyya-ux:patch-2
Open

Implement dynamic weather emoji based on conditions#69
Shreyya-ux wants to merge 6 commits into
aditya-ai00:mainfrom
Shreyya-ux:patch-2

Conversation

@Shreyya-ux

Copy link
Copy Markdown
Contributor

Added dynamic weather emoji mapping based on conditions.

Added dynamic weather emoji mapping based on conditions.
@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

@Shreyya-ux is attempting to deploy a commit to the aditya-ai00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Shreyya-ux

Copy link
Copy Markdown
Contributor Author

@aditya-ai00 sir you can now review it.

@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
weather Ready Ready Preview, Comment May 3, 2026 7:14pm

@aditya-ai00

Copy link
Copy Markdown
Owner

Hi @Shreyya-ux,

Thanks for the contribution.

I checked the preview, and there are a couple of issues:

  • The weather emoji feature is not working properly
  • Dark mode functionality is also affected

Please ensure that the emoji mapping works correctly and that existing features like dark mode are not broken.

Once these issues are fixed and everything is working properly, I’ll review it again.

Thanks!

Refactored weather emoji logic to include safety checks for data availability and ensure proper DOM updates without affecting existing styles.
@Shreyya-ux

Copy link
Copy Markdown
Contributor Author

@aditya-ai00 you can check now , if there is still problem i fix it.

@aditya-ai00

Copy link
Copy Markdown
Owner

Hi @Shreyya-ux,

Thanks for the update.

There are still merge conflicts in script.js, so I’m not able to proceed with the review yet. Please pull the latest changes from the main branch and resolve the conflicts.

Also, make sure to verify that:

  • Weather emoji mapping works correctly
  • Dark mode is not affected

Once conflicts are resolved and everything is working properly in the preview, I’ll review it again.

Thanks!

@Shreyya-ux

Copy link
Copy Markdown
Contributor Author

@aditya-ai00 conflict resolved , now u can review it.

@aditya-ai00

Copy link
Copy Markdown
Owner

Hi @Shreyya-ux,

Thanks for resolving the conflicts and updating the PR.

I tested the preview again, and there are still a few issues:

  • The weather emoji feature is not working correctly
  • Dark mode functionality is also affected
  • There may be an issue with how the API response is being handled (for example, incorrect or undefined values from data.weather[0]), which could be breaking the UI logic

Please ensure:

  • API data is being accessed safely (with proper null/undefined checks)
  • Emoji mapping works correctly for all conditions
  • Existing features like dark mode are not impacted

Once everything is working properly in the preview, I’ll review it again.

Thanks!

@Shreyya-ux

Copy link
Copy Markdown
Contributor Author

Hi @aditya-ai00, fixed the null/undefined checks for
API data and emoji update. Please review again!

@aditya-ai00

Copy link
Copy Markdown
Owner

Hi @Shreyya-ux,

Thanks for the updates.

I tested the latest preview again, and the issues are still present:

  • Weather emoji mapping is not working correctly
  • Dark mode functionality is still affected

Before I can proceed with merging, please ensure:

  1. Emoji mapping works correctly for all weather conditions (no undefined or fallback errors)
  2. API data is accessed safely (handle missing/undefined values properly)
  3. Dark mode remains fully functional and unaffected by the changes

Please test thoroughly in the preview before updating.

I’ll review again once these issues are fully resolved and stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants