feat(plugin-cc): added-werbtc-task-refactor#1
Closed
adhmenon wants to merge 5 commits into
Closed
Conversation
adhmenon
commented
Jun 19, 2025
| callOptions: {isEndCallEnabled?: boolean; isEndConsultEnabled?: boolean} = {} | ||
| ) { | ||
| super(contact, data, callOptions); | ||
| this.updateTaskUiControls({accept: [true, true], decline: [true, true]}); |
Owner
Author
There was a problem hiding this comment.
Setting up the initial buttons when the task is created.
adhmenon
commented
Jun 19, 2025
| */ | ||
| protected setUIControls(): void { | ||
| // TODO: This implementation will change based on the type of task. We need to modify it appropriately, we can even read from task data rather than listening to events | ||
| super.setUIControls(); |
Owner
Author
There was a problem hiding this comment.
Most controls will be set by the parent class, only mute needs to be set for webrtc.
By default isEndCallEnabled and isEndConsultEnabled will be true for voice task if we do not provide any flag, which is the case for webrtc.
adhmenon
commented
Jun 19, 2025
| expect(webCallingService.muteUnmuteCall).toHaveBeenCalledWith(dummyStream); | ||
| }); | ||
|
|
||
| describe('WebRTC internal methods', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #< CAI-6475 >
This pull request addresses
by making the following changes
Change Type
The following scenarios where tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.