Feat/issue 10 planet shaders#39
Open
theshantanujoshi wants to merge 5 commits into
Open
Conversation
added 5 commits
May 13, 2026 14:51
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. Installation is not linked with SafeDep Tenant. Click here to optionally link your GitHub App installation with SafeDep Tenant. This report is generated by SafeDep Github App |
Owner
|
Holding this because it inherits the #38 TypeScript failures and adds one more shader error:
Please guard or strongly type the uniform before assigning to There is also a runtime/performance issue in the same area: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This PR implements a library of procedural climate-aware shaders for planets, addressing Issue #10. It replaces the simple colored spheres with high-fidelity, climate-specific surfaces that activate upon close zoom.
Key Changes
components/galaxy/shaders/planet/for:PlacedPlanetto include physical attributes from SWAPI (climate, terrain, surface water) and added a keyword-based selector to map planets to their appropriate climate shader.MeshBasicMaterialat a distance.prefers-reduced-motionby freezing animated shader uniforms.Verification Results
Fixes #10