Skip to content

fix(training-agent): scope affected packages#5369

Open
sangilish wants to merge 1 commit into
adcontextprotocol:mainfrom
sangilish:sangilish/fix-affected-packages-mutated-only-5365
Open

fix(training-agent): scope affected packages#5369
sangilish wants to merge 1 commit into
adcontextprotocol:mainfrom
sangilish:sangilish/fix-affected-packages-mutated-only-5365

Conversation

@sangilish
Copy link
Copy Markdown
Contributor

Summary

  • Track package ids actually mutated by update_media_buy package updates and new_packages.
  • Return only those packages in affected_packages while preserving the full package snapshot in packages.
  • Add a multi-package inline-creative regression test covering the Clarify inline creative management #5365 follow-up review note.

Tests

  • npx prettier --check /tmp/adcp-minimal-5365/server/src/training-agent/task-handlers.ts /tmp/adcp-minimal-5365/server/tests/unit/training-agent.test.ts /tmp/adcp-minimal-5365/.changeset/affected-packages-mutated-only.md
  • node --check /tmp/adcp-minimal-5365/server/src/training-agent/task-handlers.ts

Follow-up for #5365.

@sangilish sangilish marked this pull request as ready for review June 5, 2026 16:55
Copy link
Copy Markdown
Contributor

@aao-release-bot aao-release-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant