fix(tmp): update Identity Match response example — missing serve_window_sec field#4469
Merged
bokelley merged 2 commits intoMay 13, 2026
Conversation
…ow_sec field The TMP Identity Match response example was not updated when the schema changed in adcontextprotocol#4070 to replace ttl_sec with serve_window_sec. This fix updates the test example to use the new required field. Fixes the test failure: "TMP Identity Match response — web (overview walkthrough)" Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
IPR Policy Agreement Required@AndyBevan — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement. To agree, post a new comment on this PR with the exact phrase: Your signature is recorded once and covers all contributions to AAO repositories. See |
Contributor
Author
|
I have read the IPR Policy |
IPR Policy — signedThanks, @AndyBevan. Your agreement to the IPR Policy is recorded at |
Contributor
|
@AndyBevan what about Note: the same ttl_sec mismatch exists in five other surface docs (surfaces/web.mdx, surfaces/mobile.mdx, surfaces/ctv.mdx, surfaces/retail-media.mdx, surfaces/ai-assistants.mdx, plus context-and-identity.mdx) |
… ttl_sec to serve_window_sec Update all TMP documentation to use serve_window_sec instead of ttl_sec in Identity Match response examples and explanations. This aligns with the schema change in adcontextprotocol#4070 where ttl_sec was replaced with serve_window_sec as the per-package single-shot frequency-cap window field. Updated files: - docs/trusted-match/index.mdx - docs/trusted-match/context-and-identity.mdx - docs/trusted-match/router-architecture.mdx - docs/trusted-match/surfaces/ai-assistants.mdx - docs/trusted-match/surfaces/ctv.mdx - docs/trusted-match/surfaces/mobile.mdx - docs/trusted-match/surfaces/retail-media.mdx - docs/trusted-match/surfaces/web.mdx Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Author
|
@brandonling27 - I actually found 8 places so fixed all of them - if any of these aren't right let me know and I'll adjust. |
Contributor
LGTM |
Contributor
Author
|
@brandonling27 - thanks, are you able to approve this PR? or does someone else do that. Thanks |
3 tasks
ohalushchak-exadel
added a commit
that referenced
this pull request
May 19, 2026
…o 3.0.x (3.0.13) (#4752) Cherry-picks three TMP changes from `main` into the `3.0.x` release line: - #4070 (`91f417f8a`) — `spec(tmp): IdentityMatch frequency-cap data flow + serve_window_sec`. Replaces `ttl_sec` on `identity-match-response` with `serve_window_sec` (integer, 1–300), reframing the field from a router response-cache TTL to a per-package single-shot fcap. Adds `specs/identitymatch-fcap-architecture.md` and `docs/trusted-match/identity-match-implementation.mdx` documenting the impression-tracker / IdentityMatch cap-state-store boundary contract. Companion doc updates across `buyer-guide`, `migration-from-axe`, `specification`. - #4469 (`7fd2ff0e4`) — `fix(tmp): update Identity Match response example — missing serve_window_sec field`. Required follow-up: every doc example payload across overview, surfaces (web/ctv/mobile/retail-media/ai-assistants), router-architecture, and context-and-identity walkthroughs needs `serve_window_sec` to satisfy the new schema constraint, plus the example-validation test fixture. Combined into this commit because #4070's schema change breaks the example-validation suite without it. - #3706 (`b27368d3f`) — `docs: add TMP data protection roles page mapping GDPR controller/processor`. New `docs/trusted-match/data-protection-roles.mdx` mapping TMP architecture to GDPR controller/processor roles (router, buyer agent, publisher), with risks requiring DPA scrutiny and publisher configuration choices. Wired into `docs.json` nav and cross-linked from `privacy-architecture.mdx` and `reference/privacy-considerations.mdx`. Conflict resolutions: - `static/schemas/source/tmp/identity-match-response.json`: dropped the `allOf` / `version-envelope` block from #4070's patch — `static/schemas/source/core/version-envelope.json` does not exist on 3.0.x, so the reference would be dangling. The `serve_window_sec` field and updated description were taken as-is. - `CHANGELOG.md`: kept the 3.0.x version; the release tooling regenerates the CHANGELOG entry from `.changeset/*.md` at the next release cut. Changeset levels match the 3.0.x patch convention: - `identitymatch-fcap-architecture-spec.md`: `patch` (already at patch on `main` — TMP is `x-status: experimental`, additive-field changes are non-breaking on the stable line). - `tmp-data-protection-roles-doc.md`: empty frontmatter (docs-only, no version bump on its own — release is driven by the fcap changeset). Drives the next release cut as 3.0.13. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the TMP Identity Match response test example to use the new
serve_window_secfield introduced in #4070.Problem
The test suite was failing with:
❌ TMP Identity Match response — web (overview walkthrough): root: must have required property 'serve_window_sec'
The schema was updated in #4070 to replace
ttl_secwith the newserve_window_secfield (per-package single-shot frequency-cap window), but the test example intests/example-validation-simple.test.cjswas not updated.
Solution
Updated the test example at line 584 to use
serve_window_sec: 60instead ofttl_sec: 60.Testing
Related Issues