Skip to content

test(adcp): harden plan audit Budget.Committed explicit-zero round-trip #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bokelley wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test(adcp): harden plan audit Budget.Committed explicit-zero round-trip #310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aff6da
test(adcp): add explicit Budget.Committed zero round-trip case
claude May 29, 2026
62feb1b
test(adcp): address pre-PR review nits for issue-306
claude May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions adcp/generated_core_refs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,31 @@ func TestPlanAuditLogsRoundTrip(t *testing.T) {
if strings.Contains(body, `"committed":null`) {
t.Fatalf("plan audit logs unexpectedly marshaled absent budget.committed:\n%s", body)
}

// Contrast: budget.committed explicitly zero must round-trip as "committed":0 inside
// the "budget" object, not be omitted. The governed_actions entry also has "committed":0
// (a non-pointer float64) — the scoped assertion on the "budget" object confirms we are
// checking PlanAuditBudget.Committed (*float64), not PlanAuditGovernedAction.Committed.
raw2 := []byte(`{"plans":[{"plan_id":"plan-2","plan_version":1,"status":"active","budget":{"authorized":5000,"committed":0},"summary":{},"governed_actions":[{"governance_context":"ctx-1","purchase_type":"media_buy","status":"active","committed":0,"check_count":0}]}]}`)
var decoded2 GetPlanAuditLogsResponse
if err2 := json.Unmarshal(raw2, &decoded2); err2 != nil {
t.Fatalf("unmarshal plan audit logs with explicit committed zero: %v", err2)
}
if len(decoded2.Plans) != 1 {
t.Fatalf("plans len = %d, want 1", len(decoded2.Plans))
}
plan2 := decoded2.Plans[0]
if plan2.Budget.Committed == nil || *plan2.Budget.Committed != 0 {
t.Fatalf("budget.committed = %#v, want explicit pointer to 0", plan2.Budget.Committed)
}
encoded2, err2 := json.Marshal(decoded2)
if err2 != nil {
t.Fatalf("marshal plan audit logs with explicit committed zero: %v", err2)
}
if !strings.Contains(string(encoded2), `"budget":{"authorized":5000,"committed":0}`) {
t.Fatalf("explicit Budget.Committed:0 did not round-trip inside budget object"+
" (Budget.Committed is *float64; nil pointer is omitted, pointer-to-zero is emitted even with omitempty):\n%s", encoded2)
}
}

func TestGovernanceFindingsRoundTrip(t *testing.T) {
Expand Down
Loading