Skip to content

HTTP Request Compression for ADBRO Bid Adapter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
inebritov wants to merge 2 commits into from
Closed

HTTP Request Compression for ADBRO Bid Adapter #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
847dcbf
Configured HTTP Request Compression for ADBRO Bid Adapter
inebritov Jan 15, 2026
97bede2
ADBRO Bid Adapter Request Compression test is moved out to separate s…
inebritov Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/adbroBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ export const spec = {
result.push({
method: 'POST',
url: ENDPOINT_URL + '?placementId=' + id,
options: {
endpointCompression: true,
},
data
});
});
Expand Down
6 changes: 6 additions & 0 deletions test/spec/modules/adbroBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ describe('adbroBidAdapter', function () {
expect(serverRequest.data).to.exist;
});

it('Configures compression for the ServerRequest object', function () {
const serverRequest = serverRequests[0];
expect(serverRequest.options).to.exist;
expect(serverRequest.options.endpointCompression).to.be.true;

@ashvetsov ashvetsov Jan 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a dedicated test case within the same group:

it('Configures compression for the ServerRequest object', function () {
  const serverRequest = serverRequests[0];
  expect(serverRequest.options).to.exist;
  expect(serverRequest.options.endpointCompression).to.be.true;
}

It's always better to add new test cases than to modify existing ones.

});

it('Returns general data valid', function () {
const data = serverRequests[0].data;
expect(data).to.be.an('object');
Expand Down
Loading