Skip to content

fix(go): skip MySQL session timezone for non-MySQL backends and test with Databend - #122

Merged
Mandukhai-Alimaa merged 7 commits into
adbc-drivers:mainfrom
Mandukhai-Alimaa:fix/timezone-errors
Jul 29, 2026
Merged

fix(go): skip MySQL session timezone for non-MySQL backends and test with Databend#122
Mandukhai-Alimaa merged 7 commits into
adbc-drivers:mainfrom
Mandukhai-Alimaa:fix/timezone-errors

Conversation

@Mandukhai-Alimaa

@Mandukhai-Alimaa Mandukhai-Alimaa commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Only inject MySQL's session time_zone parameter for MySQL and MariaDB.
Add Databend validation coverage and workflow matrix entries.

Running the validation suite before the fix reproduces the issue, and after the fix, it runs successfully and connects to Databend.

Closes #61

This needs to be merged in first adbc-drivers/validation#271

Comment thread go/validation/tests/test_statement.py
Comment thread go/validation/tests/test_connection.py Outdated
Comment thread go/validation/queries/databend/type/select/timestamptz.txtcase Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally when we have vendor = Databend we could parse this regardless but that can be done separately

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue for it #126

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we investigate this as a followup? Presumably DECIMAL works in other clients?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created issue for it too. #127

@Mandukhai-Alimaa
Mandukhai-Alimaa merged commit 049732a into adbc-drivers:main Jul 29, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

time_zone errors

2 participants