Skip to content

fix: minor issues with go_mod_path construction and use - #145

Merged
lidavidm merged 3 commits into
adbc-drivers:mainfrom
amoeba:fix/generate-minor-tweaks
Apr 14, 2026
Merged

fix: minor issues with go_mod_path construction and use#145
lidavidm merged 3 commits into
adbc-drivers:mainfrom
amoeba:fix/generate-minor-tweaks

Conversation

@amoeba

@amoeba amoeba commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

What's Changed

Fixes two minor things with go_mod_path. Without this, the generated dev.yaml will use a hard coded go/go.mod path. I missed this in aa2b3ac. The other thing is just a minor safety thing, that go_mod_path didn't have a default.

Tested locally with a test repo:

$ cat .github/workflows/generate.toml | grep subdir
subdir = "."
$ adbc-gen-workflow generate .
$ grep "go\." ".github/workflows/dev.yaml"
          cache-dependency-path: ./go.sum
          go-version-file: ./go.mod

@amoeba
amoeba requested a review from lidavidm as a code owner April 14, 2026 02:06

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I need to handle #29, though I'm not quite sure what a good test even looks like (e.g. one that could even capture this)

@lidavidm

Copy link
Copy Markdown
Contributor

Note that pre-commit is failing

@amoeba
amoeba requested a review from lidavidm April 14, 2026 16:20
@amoeba

amoeba commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Pre-commit is fixed. Re-requested review since I can't merge.

@lidavidm
lidavidm merged commit 2b9ef43 into adbc-drivers:main Apr 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants