Bundle AsyncTI4 resources in PyPI artifacts and support installed-package resource paths - #40
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/adam133/ti4-rules-engine/sessions/f3f8250b-ad86-42ed-86b3-d08a0d35f6d8 Co-authored-by: adam133 <20442729+adam133@users.noreply.github.com>
Agent-Logs-Url: https://github.com/adam133/ti4-rules-engine/sessions/f3f8250b-ad86-42ed-86b3-d08a0d35f6d8 Co-authored-by: adam133 <20442729+adam133@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
adam133
April 17, 2026 17:25
View session
adam133
marked this pull request as ready for review
April 17, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analyze()failed in PyPI installs because AsyncTI4resourceswere not shipped in the distribution and path resolution only targeted repo-style layouts. This change makes packaged installs self-contained and resolves resources from both source and installed contexts.Packaging: ship full AsyncTI4 resources
pyproject.tomlto includedata/TI4_map_generator_bot/src/main/resourcesin both build targets:ti4_rules_engine/data/.../resourcesresourcestree (not onlyresources/data)Runtime path resolution: support packaged layout
_data_paths.pyto search multiple candidate locations:data/TI4_map_generator_bot/src/main/resources(repo checkout)ti4_rules_engine/data/TI4_map_generator_bot/src/main/resources(installed package)Regression coverage
_locate_asyncti4_resources_dir()covering both repo-style and packaged-style directory structures.