Enforce submodule-only AsyncTI4 data loading and add PR gate for pbd22635 analysis + unit tests - #38
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/adam133/ti4-rules-engine/sessions/311573eb-3481-44fa-a576-fba9dbe391b8 Co-authored-by: adam133 <20442729+adam133@users.noreply.github.com>
Agent-Logs-Url: https://github.com/adam133/ti4-rules-engine/sessions/311573eb-3481-44fa-a576-fba9dbe391b8 Co-authored-by: adam133 <20442729+adam133@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
adam133
April 17, 2026 01:48
View session
adam133
marked this pull request as ready for review
April 17, 2026 01:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analyze workflow was partially loading data from non-repo locations, which caused missing datasets (notably hyperlanes) and fallback behavior that masked data integrity issues. This change makes data loading strict: all required datasets must come from the local AsyncTI4 submodule, or execution fails fast.
Data source hardening (no partial fallbacks)
scripts/_data_paths.py.Removed incomplete/remote fallback paths
Workflow coverage for this regression
.github/workflows/pr-unit-tests.ymlonpull_requesttomain.ti4-analyze "pbd22635"and thenpython -m pytest tests.Tests updated for strict behavior