fix: cpSync the asset directory#57
Merged
Merged
Conversation
| if (testAssetsDir) { | ||
| const targetDir = path.resolve(assetsPath, "test-assets"); | ||
| fs.copyFileSync(testAssetsDir, targetDir); | ||
| fs.cpSync(testAssetsDir, targetDir, { recursive: true }); |
Contributor
There was a problem hiding this comment.
Thanks @WilcoFiers I applied this same patch locally, and then run the script, which accidentally committed the changes. I am not sure there are that many changes to the test cases since we last published.
Jym77
approved these changes
Jun 10, 2026
daniel-montalvo
approved these changes
Jun 10, 2026
daniel-montalvo
left a comment
daniel-montalvo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @WilcoFiers for working on this. Approving. Related to my earlier comment about the unexpected changes to test cases, I guess we'll wait and see and if there's something wrong with those we'll comment on the WAI pr publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/act-rules/act-rules.github.io/actions/runs/27199870005/job/80300857945