feat(service): add StopTimeout option to wait for Unit.Start to exit#60
Merged
Merged
Conversation
StartContext previously returned as soon as Unit.Stop completed, leaving the Start goroutine running in the background. The new Opts.StopTimeout, when > 0, makes StartContext block up to the configured duration for Start to exit, logging a warning on timeout. Zero preserves the prior non-waiting behavior.
vasayxtx
force-pushed
the
stop-timeout-for-service-start
branch
from
312a473 to
ca7c708
Compare
jalankulkija
approved these changes
May 13, 2026
klukyanov76
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartContext previously returned as soon as Unit.Stop completed, leaving the Start goroutine running in the background. The new Opts.StopTimeout, when > 0, makes StartContext block up to the configured duration for Start to exit, logging a warning on timeout. Zero preserves the prior non-waiting behavior.