Sync fork with upstream/master - #3
Merged
Merged
Conversation
Alex (ahornsby-acquired)
approved these changes
Jul 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR syncs the fork to the latest upstream/master and incorporates upstream refactors and dependency/test-framework upgrades across the connector library, web app, and test suites.
Changes:
- Migrates test projects away from FluentAssertions and updates test SDK/framework packages (xUnit v3 / FsCheck v3, MSTest updates).
- Reworks HTTP error handling to use structured
ServerError+HttpResponseException, with additional consent/auth-context server error types. - Adds/updates bank profile support (e.g., Wise, Zopa; additional HSBC/Nationwide variants) and adjusts related configuration/custom behaviours.
Reviewed changes
Copilot reviewed 162 out of 163 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/OpenBanking.Library.Connector.UnitTests/Security/KeySecretTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Security/CertificateExtensionsTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/OpenBanking.Library.Connector.UnitTests.csproj | Updates test SDK/packages (xUnit v3, FsCheck v3) and removes FluentAssertions. |
| test/OpenBanking.Library.Connector.UnitTests/Model/Validation/AuthorisationCallbackDataValidatorTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Model/Public/GenereatedModelImplementationTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Model/Payments/GeneratedModelImplementationTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Mapping/EntityTypeFinderTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Mapping/EntityMapperTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Json/OBTypesTests.cs | Uses xUnit v3 equivalency assertions in JSON roundtrip tests. |
| test/OpenBanking.Library.Connector.UnitTests/Instrumentation/ConsoleInstrumentationClientTests.cs | Replaces FluentAssertions string assertions with xUnit equivalents. |
| test/OpenBanking.Library.Connector.UnitTests/Http/HttpRequestInfoPropertyAttribute.cs | Improves FsCheck property metadata via caller info parameters. |
| test/OpenBanking.Library.Connector.UnitTests/Http/HttpRequestInfoExtensionsTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Http/ApiClientTests.cs | Updates asserts + adapts to updated HTTP helper signatures/cancellation usage. |
| test/OpenBanking.Library.Connector.UnitTests/ExtensionsTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.UnitTests/Extensions/StringExtensionTests.cs | Replaces FluentAssertions with xUnit assertions. |
| test/OpenBanking.Library.Connector.IntegrationTests/Persistence/DomesticConsentRepoTests.cs | Adjusts test framework imports to align with updated packages. |
| test/OpenBanking.Library.Connector.IntegrationTests/Persistence/BankClientProfileDbRepoTests.cs | Adjusts test framework imports to align with updated packages. |
| test/OpenBanking.Library.Connector.IntegrationTests/OpenBanking.Library.Connector.IntegrationTests.csproj | Updates test SDK/packages (xUnit v3, FsCheck v3) and removes FluentAssertions. |
| test/OpenBanking.Library.Connector.IntegrationTests/LocalMockTests/Http/ApiClientTests.cs | Updates asserts and async test signature for updated xUnit patterns. |
| test/OpenBanking.Library.Connector.BankTests/wwwroot/auth/js/main.js | Adds fragment-redirect helper script for bank tests’ auth flow. |
| test/OpenBanking.Library.Connector.BankTests/wwwroot/auth/fragment-redirect.html | Normalizes HTML header/encoding for bank test redirect page. |
| test/OpenBanking.Library.Connector.BankTests/TestingMethods.cs | Moves testing hooks into BankTests namespace; keeps registration helpers. |
| test/OpenBanking.Library.Connector.BankTests/TestingAuthResult.cs | Moves DTO into BankTests namespace. |
| test/OpenBanking.Library.Connector.BankTests/RedirectObserver.cs | Removes dependency on old Web namespace for test redirect observation. |
| test/OpenBanking.Library.Connector.BankTests/RedirectObservable.cs | Removes dependency on old Web namespace for test redirect observation. |
| test/OpenBanking.Library.Connector.BankTests/OpenBanking.Library.Connector.BankTests.csproj | Updates MSTest SDK + embeds static resources for test web host. |
| test/OpenBanking.Library.Connector.BankTests/Instrumentation/TestOutputLoggerProvider.cs | Adds MSTest-context logger provider to keep parallel test logs correctly routed. |
| test/OpenBanking.Library.Connector.BankTests/GlobalUsings.cs | Adds Wise/Zopa global aliases for bank-test compilation paths. |
| test/OpenBanking.Library.Connector.BankTests/FunctionalSubtests/VariableRecurringPayments/DomesticVrpConsent/DomesticVrpConsentSubtest.cs | Makes request logging optional; uses DI scopes via CreateScope(). |
| test/OpenBanking.Library.Connector.BankTests/FunctionalSubtests/PaymentInitiation/DomesticPaymentConsent/DomesticPaymentConsentSubtest.cs | Makes request logging optional; guards writes when logging disabled. |
| test/OpenBanking.Library.Connector.BankTests/FunctionalSubtests/AccountAndTransaction/AccountAccessConsent/AccountAccessConsentSubtest.cs | Adds post-create delay support; makes request logging optional; uses DI scopes. |
| test/OpenBanking.Library.Connector.BankTests/Extensions/ServiceCollectionExtensions.cs | Switches to Options binding + startup validation for bank test settings. |
| test/OpenBanking.Library.Connector.BankTests/Extensions/ApplicationBuilderExtensions.cs | Moves static file hosting helpers into BankTests namespace and uses embedded manifests. |
| test/OpenBanking.Library.Connector.BankTests/Controllers/VariableRecurringPayments/TestingDomesticVrpConsentsController.cs | Moves test controller into BankTests and removes RequestBuilder fallback. |
| test/OpenBanking.Library.Connector.BankTests/Controllers/PaymentInitiation/TestingDomesticPaymentConsentsController.cs | Moves test controller into BankTests and removes RequestBuilder fallback. |
| test/OpenBanking.Library.Connector.BankTests/Controllers/AuthContext/TestingRedirectsController.cs | Introduces BankTests-only redirect endpoints for query/fragment redirect handling. |
| test/OpenBanking.Library.Connector.BankTests/Controllers/AccountAndTransaction/TestingAccountAccessConsentsController.cs | Moves test controller into BankTests and removes RequestBuilder fallback. |
| test/OpenBanking.Library.Connector.BankTests/Configuration/BankTestSettingsValidator.cs | Adds Options validator (executable path validation) for bank-test settings. |
| test/OpenBanking.Library.Connector.BankTests/Configuration/BankTestSettings.cs | Simplifies settings object and defines configuration section name constant. |
| test/OpenBanking.Library.Connector.BankTests/BrowserInteraction/ConsentAuth.cs | Switches auth email from plain text to HTML link format. |
| test/OpenBanking.Library.Connector.BankTests/BrowserInteraction/BankUiMethods/BarclaysUiMethods.cs | No-op Barclays UI automation (placeholder implementation). |
| test/OpenBanking.Library.Connector.BankTests/BankTests/WebAppClient.cs | Updates assertions to MSTest Assert APIs. |
| test/OpenBanking.Library.Connector.BankTests/BankTests/ManagementApiClient.cs | Updates assertions to MSTest Assert APIs. |
| test/OpenBanking.Library.Connector.BankTests/BankTests/BankTestingFixture.cs | Configures logging to use TestOutput provider; preserves execution context for AsyncLocal. |
| test/OpenBanking.Library.Connector.BankTests/BankTests/AuthContextsApiClient.cs | Updates assertions to MSTest Assert APIs. |
| test/OpenBanking.Library.Connector.BankTests/BankTests/AppTests.cs | Adds Wise/Zopa test cases; shifts settings retrieval to Options; removes file logging plumbing. |
| test/OpenBanking.Library.Connector.BankTests/BankTests/AppContextFixture.cs | Updates host service wiring and logging configuration for BankTests web host. |
| test/OpenBanking.Library.Connector.BankTests/BankTests/AccountAndTransactionApiClient.cs | Updates assertions to MSTest Assert APIs and aligns with new response expectations. |
| test/OpenBanking.Library.Connector.BankTests/AppConfiguration.cs | Removes legacy settings accessor (moves away from prior settings provider pattern). |
| src/OpenBanking.WebApp.Connector/wwwroot/index.html | Removes link to non-production testing fragment redirect page from web app index. |
| src/OpenBanking.WebApp.Connector/Program.cs | Rewires service registration/logging; removes “test” Swagger doc; adds OTEL ASP.NET instrumentation hook. |
| src/OpenBanking.WebApp.Connector/OpenBanking.WebApp.Connector.csproj | Updates package versions; adds OTEL ASP.NET instrumentation package; references GenericHost project. |
| src/OpenBanking.WebApp.Connector/Filters/GlobalExceptionFilter.cs | Switches exception handling to structured ServerError mapping into ProblemDetails. |
| src/OpenBanking.WebApp.Connector/Filters/ExternalApiHttpErrorExceptionFilter.cs | Narrows filter to deserialisation exception and conditionally exposes response body. |
| src/OpenBanking.Library.Connector/Security/JwtFactory.cs | Adds jose-jwt options for payload encoding/detached payload support. |
| src/OpenBanking.Library.Connector/Operations/VariableRecurringPayments/DomesticVrpConsentOperations.cs | Updates consent loading to include consent-id source; aligns token acquisition and id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/VariableRecurringPayments/DomesticVrpConsentDelete.cs | Updates consent loading to include consent-id source. |
| src/OpenBanking.Library.Connector/Operations/VariableRecurringPayments/DomesticVrpConsentCommon.cs | Replaces KeyNotFoundException with structured consent-not-found server errors. |
| src/OpenBanking.Library.Connector/Operations/VariableRecurringPayments/DomesticVrpConsentAuthContextOperations.cs | Updates consent loading to include request-body source. |
| src/OpenBanking.Library.Connector/Operations/VariableRecurringPayments/DomesticVrp.cs | Updates consent loading to include request-body source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/PaymentInitiation/DomesticPaymentConsentOperations.cs | Updates consent loading to include URL-path source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/PaymentInitiation/DomesticPaymentConsentCommon.cs | Replaces KeyNotFoundException with structured consent-not-found server errors. |
| src/OpenBanking.Library.Connector/Operations/PaymentInitiation/DomesticPaymentConsentAuthContextOperations.cs | Updates consent loading to include request-body source. |
| src/OpenBanking.Library.Connector/Operations/PaymentInitiation/DomesticPayment.cs | Updates consent loading to include request-body source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/OpenIdConfigurationRead.cs | Updates HTTP helper call to new signature with success-body exposure flag. |
| src/OpenBanking.Library.Connector/Operations/Management/BankRegistrationOperations.cs | Adds Wise/Zopa registration support; expands JSON converter option mapping for DCR claims. |
| src/OpenBanking.Library.Connector/Operations/LinksUrlOperations.cs | Fixes list mutation logic by iterating over a stable initial count. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/PaymentInitiation/PaymentInitiationPostRequestProcessor.cs | Uses detached JWS in header and updates HTTP helper signature usage. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/IGrantPost.cs | Updates grant post API to accept base ID token processing custom behaviour. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/IdTokenValidationError.cs | Adds structured server error type for ID token validation failures. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/BankConfiguration/BankRegistrationPostRequestProcessor.cs | Updates HTTP helper call signature and success-body exposure flag. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/BankConfiguration/BankRegistrationGetRequestProcessor.cs | Updates HTTP helper call signature and success-body exposure flag. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/AuthGrantPostRequestProcessor.cs | Updates HTTP helper call signature and success-body exposure flag. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/ApiGetRequestProcessor.cs | Updates HTTP helper call signature and success-body exposure flag. |
| src/OpenBanking.Library.Connector/Operations/ExternalApi/AccountAndTransaction/AccountAndTransactionPostRequestProcessor.cs | Updates HTTP helper call signature and success-body exposure flag. |
| src/OpenBanking.Library.Connector/Operations/CreateAuthUrl.cs | Allows consent auth custom behaviour to override authorization endpoint. |
| src/OpenBanking.Library.Connector/Operations/ConsentServerErrors.cs | Adds structured consent-not-found error types and consent-id source handling. |
| src/OpenBanking.Library.Connector/Operations/ConsentAccessTokenGet.cs | Passes base ID token processing custom behaviour into refresh-token grant processing. |
| src/OpenBanking.Library.Connector/Operations/AuthContextServerErrors.cs | Adds structured auth-context server errors. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/TransactionGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/StandingOrderGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/PartyGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/Party2Get.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/MonzoPotGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/DirectDebitGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/BalanceGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/AccountGet.cs | Updates consent loading to use request-header source; aligns token acquisition/id-token processing plumbing. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/AccountAccessConsentOperations.cs | Updates consent loading to include URL-path source. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/AccountAccessConsentDelete.cs | Updates consent loading to include URL-path source. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/AccountAccessConsentCommon.cs | Replaces KeyNotFoundException with structured consent-not-found server errors. |
| src/OpenBanking.Library.Connector/Operations/AccountAndTransaction/AccountAccessConsentAuthContextOperations.cs | Updates consent loading to include request-body source. |
| src/OpenBanking.Library.Connector/OpenBanking.Library.Connector.csproj | Updates dependency versions (AutoMapper, jose-jwt, EFCore, OTEL, etc.). |
| src/OpenBanking.Library.Connector/Models/Public/Management/IdTokenSubClaimType.cs | Adds ClientId option for ID token sub claim handling. |
| src/OpenBanking.Library.Connector/Models/Configuration/OpenTelemetrySettings.cs | Adds processed exporter URL helpers and “has exporter” flags; tweaks defaults. |
| src/OpenBanking.Library.Connector/Mapping/ApiVariantMappingConfiguration.cs | Supplies NullLoggerFactory to AutoMapper config to match updated AutoMapper API. |
| src/OpenBanking.Library.Connector/Http/IApiClient.cs | Adds exposeSuccessResponseBodyInError parameter to JSON-response helper API. |
| src/OpenBanking.Library.Connector/Http/HttpRequestBuilder.cs | Propagates new exposeSuccessResponseBodyInError parameter to IApiClient. |
| src/OpenBanking.Library.Connector/Http/ExternalApiHttpRequestErrors.cs | Introduces structured server errors for external API HTTP request failures/timeouts/I/O. |
| src/OpenBanking.Library.Connector/Http/ExternalApiHttpErrorException.cs | Removes legacy exception type in favour of structured server errors. |
| src/OpenBanking.Library.Connector/Http/ExternalApiDeserialisationException.cs | Adds flag to control whether success-body is exposed when deserialisation fails. |
| src/OpenBanking.Library.Connector/GlobalUsings.cs | Adds Wise/Zopa global aliases across connector project. |
| src/OpenBanking.Library.Connector/Fluent/HttpResponseException.cs | Replaces title/status/extensions model with structured ServerError. |
| src/OpenBanking.Library.Connector/Extensions/StringExtensions.cs | Adds ToCamelCase and PascalCase-to-words helper used for error formatting. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/ZopaGenerator.cs | Adds Zopa bank profile generator with custom behaviours. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/WiseGenerator.cs | Adds Wise bank profile generator and custom behaviours for known quirks. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/TsbGenerator.cs | Moves ID token sub-claim handling into base ID-token processing custom behaviour. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/TideGenerator.cs | Removes AspspBrandId usage from profile initialization. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/StarlingGenerator.cs | Adds PISP support and refines ID token processing behaviours. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/SantanderGenerator.cs | Moves ID token sub-claim handling into base ID-token processing custom behaviour. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/RevolutGenerator.cs | Updates issuer URL and simplifies consent-auth custom behaviour properties. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/ObieGenerator.cs | Removes AspspBrandId usage from profile initialization. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/MonzoGenerator.cs | Removes AspspBrandId usage from profile initialization. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/LloydsGenerator.cs | Makes VRP v4 conditional; moves ID token sub-claim handling into base behaviour; removes AspspBrandId usage. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/HsbcGenerator.cs | Adds M&S variant and makes APIs optional for that profile; removes AspspBrandId usage. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/DanskeGenerator.cs | Removes AspspBrandId usage from profile initialization. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/CooperativeGenerator.cs | Removes AspspBrandId usage from profile initialization. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/ChaseGenerator.cs | Moves ID token sub-claim handling into base ID-token processing custom behaviour; removes AspspBrandId usage. |
| src/OpenBanking.Library.Connector/BankProfiles/Generators/BarclaysGenerator.cs | Marks sandbox unsupported; moves ID token sub-claim handling into base behaviour; removes sandbox-only code and AspspBrandId usage. |
| src/OpenBanking.Library.Connector/BankProfiles/CustomBehaviour/RefreshTokenGrantPostCustomBehaviour.cs | Adds option to control whether scope is included in refresh-token requests. |
| src/OpenBanking.Library.Connector/BankProfiles/CustomBehaviour/Management/BankRegistrationPostCustomBehaviour.cs | Adds converter options for issued-at and expiration-time claim parsing. |
| src/OpenBanking.Library.Connector/BankProfiles/CustomBehaviour/IdTokenProcessingCustomBehaviour.cs | Introduces base + endpoint-specific resolution helpers for ID token validation behaviours. |
| src/OpenBanking.Library.Connector/BankProfiles/CustomBehaviour/CustomBehaviourClass.cs | Adds BaseIdTokenProcessingCustomBehaviour as a default override source. |
| src/OpenBanking.Library.Connector/BankProfiles/CustomBehaviour/ConsentAuthGetCustomBehaviour.cs | Allows overriding the authorization endpoint URL. |
| src/OpenBanking.Library.Connector/BankProfiles/CustomBehaviour/AuthCodeGrantPostCustomBehaviour.cs | Adds option to control whether scope is included in auth-code grant requests. |
| src/OpenBanking.Library.Connector/BankProfiles/BankProfileService.cs | Registers Wise/Zopa bank profile generators. |
| src/OpenBanking.Library.Connector/BankProfiles/BankProfileExtensions.cs | Maps new bank profiles (Wise/Zopa/HSBC M&S/Nationwide VirginMerged) to bank groups. |
| src/OpenBanking.Library.Connector/BankProfiles/BankProfileEnum.cs | Adds new bank profile enum values and marks Barclays sandbox obsolete. |
| src/OpenBanking.Library.Connector/BankProfiles/BankProfile.cs | Removes AspspBrandId; adds AccountAccessConsent post-create delay setting. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/Zopa.cs | Adds Zopa bank group definitions. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/Wise.cs | Adds Wise bank group definitions. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/Nationwide.cs | Adds Nationwide VirginMerged variant mapping. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/Hsbc.cs | Adds HSBC M&S variant mapping. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/Barclays.cs | Marks sandbox obsolete and suppresses obsolete warnings where required. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/BankGroupExtensions.cs | Registers Wise/Zopa bank groups. |
| src/OpenBanking.Library.Connector/BankProfiles/BankGroups/BankGroup.cs | Adds Wise and Zopa to BankGroup enum. |
| src/OpenBanking.Library.Connector.Web/OpenBanking.Library.Connector.Web.csproj | Simplifies Web project references (depends on Connector core) and removes embedded/static + OTEL packages here. |
| src/OpenBanking.Library.Connector.Web/Models/Public/Response/HttpResponseMessages.cs | Removes legacy Web HTTP response wrapper model. |
| src/OpenBanking.Library.Connector.Web/Models/Public/Response/HttpResponse.cs | Removes legacy Web HTTP response wrapper model. |
| src/OpenBanking.Library.Connector.Web/HostedServices/WebAppInformationHostedService.cs | Improves startup logging, adds service version logging, and logs endpoints on ApplicationStarted. |
| src/OpenBanking.Library.Connector.Web/Extensions/ServiceCollectionExtensions.cs | Removes OTEL wiring from Web project; keeps hosted services/health checks and supports service version injection. |
| src/OpenBanking.Library.Connector.Web/Extensions/FluentResponseExtensions.cs | Removes Fluent-to-HTTP response wrapper conversion helpers (legacy model removed). |
| src/OpenBanking.Library.Connector.Web/Controllers/ErrorController.cs | Cleans up unused commented validation handling in error controller. |
| src/OpenBanking.Library.Connector.Web/Controllers/AuthContext/TestingRedirectsController.cs | Removes test-only controller from Web project (moved into BankTests). |
| src/OpenBanking.Library.Connector.GenericHost/OpenBanking.Library.Connector.GenericHost.csproj | Updates dependency versions and adds OpenTelemetry exporter/instrumentation packages. |
| src/OpenBanking.Library.BankApiModels/UkObDcr/V3p3/Models/OBClientRegistration1.cs | Adds labelled Unix timestamp converters for DCR iat/exp. |
| src/OpenBanking.Library.BankApiModels/UkObDcr/V3p2/Models/OBClientRegistration1.cs | Adds labelled Unix timestamp converters for DCR iat/exp. |
| src/OpenBanking.Library.BankApiModels/UkObDcr/V3p1/Models/OBClientRegistration1.cs | Adds labelled Unix timestamp converters for DCR iat/exp. |
| src/OpenBanking.Library.BankApiModels/OpenBanking.Library.BankApiModels.csproj | Updates dependency versions (AutoMapper, jose-jwt). |
| src/OpenBanking.Library.BankApiModels/Json/JsonConverterLabel.cs | Adds new labels for DCR issued-at and expiration-time fields. |
| docs/apis/variable-recurring-payments/openapi-vrp.json | Bumps published API version to 20.0.0. |
| docs/apis/payment-initiation/openapi-pisp.json | Bumps published API version to 20.0.0. |
| docs/apis/management/openapi-manage.json | Bumps published API version to 20.0.0 and updates enums for new bank groups/profiles. |
| docs/apis/auth-contexts/openapi-auth.json | Bumps published API version to 20.0.0. |
| docs/apis/account-and-transaction/openapi-aisp.json | Bumps published API version to 20.0.0. |
Comments suppressed due to low confidence (3)
test/OpenBanking.Library.Connector.BankTests/Controllers/AccountAndTransaction/TestingAccountAccessConsentsController.cs:40
- Throwing
InvalidOperationException()without a message makes test failures and logs hard to diagnose. Include a message telling the caller which TestingMethods registration is missing.
test/OpenBanking.Library.Connector.BankTests/Controllers/PaymentInitiation/TestingDomesticPaymentConsentsController.cs:40 - Throwing
InvalidOperationException()without a message makes test failures and logs hard to diagnose. Include a message telling the caller which TestingMethods registration is missing.
test/OpenBanking.Library.Connector.BankTests/Controllers/VariableRecurringPayments/TestingDomesticVrpConsentsController.cs:40 - Throwing
InvalidOperationException()without a message makes test failures and logs hard to diagnose. Include a message telling the caller which TestingMethods registration is missing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the fork up to date with the latest
upstream/master(finlabsuk), 49 commits behind. The branch tip is byte-identical to upstream.ExternalApiHttpErrorExceptiontoExternalApiHttpRequestFailure) and moved testing controllers/filters between projects.Details for AI reviewers
What this is: a fork-sync merge, not a feature change. Every code change originates from
upstream/master; nothing was authored here beyond the merge commit itself.Verification
git diff --quiet HEAD upstream/masterreports no difference: the branch tip matches upstream exactly.gpgsigheader present), so it satisfies the "require signed commits" branch rule that blocked the web sync.Notable upstream changes
ExternalApiHttpErrorExceptionremoved in favour ofExternalApiHttpRequestFailureresponse objects; newExternalApiHttpRequestErrors,ConsentServerErrors,AuthContextServerErrors,IdTokenValidationError.OpenBanking.Library.Connector.WebintoOpenBanking.Library.Connector.BankTests/OpenBanking.WebApp.Connector.