Skip to content

Remove dead header and a redundant edge record#157

Merged
nclack merged 2 commits into
acquire-project:mainfrom
nclack:cleanup-dead-code
Jun 17, 2026
Merged

Remove dead header and a redundant edge record#157
nclack merged 2 commits into
acquire-project:mainfrom
nclack:cleanup-dead-code

Conversation

@nclack

@nclack nclack commented Jun 13, 2026

Copy link
Copy Markdown
Member

Two small, behavior-neutral cleanups flagged during the orchestration-migration reviews (#143/#148/#149/#151).

  • Remove dead flush.helpers.h. The header had no remaining users after the scheduler work; deleted the file, its two #includes, and the CMakeLists entry. Verified no symbol it declared is referenced anywhere.
  • Drop a redundant POOL_FILLED record. On the drain-after-kick (multiarray sync) schedule, schedule_accumulate_epoch recorded the pool-filled edge and then schedule_flush_accumulated recorded it again on the same stream. Skip the first on that path; the flush-accumulated release is the load-bearing one before its kick. The pipelined and drain-before-kick paths are unchanged.

Validation (L40, sm_89, RelWithDebInfo): ctest -E "(s3)" 48/48; zero new warnings.

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nclack nclack merged commit 52dab8e into acquire-project:main Jun 17, 2026
8 checks passed
@nclack nclack deleted the cleanup-dead-code branch June 17, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant