Remove dead header and a redundant edge record#157
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, behavior-neutral cleanups flagged during the orchestration-migration reviews (#143/#148/#149/#151).
flush.helpers.h. The header had no remaining users after the scheduler work; deleted the file, its two#includes, and the CMakeLists entry. Verified no symbol it declared is referenced anywhere.POOL_FILLEDrecord. On the drain-after-kick (multiarray sync) schedule,schedule_accumulate_epochrecorded the pool-filled edge and thenschedule_flush_accumulatedrecorded it again on the same stream. Skip the first on that path; the flush-accumulated release is the load-bearing one before its kick. The pipelined and drain-before-kick paths are unchanged.Validation (L40, sm_89, RelWithDebInfo):
ctest -E "(s3)"48/48; zero new warnings.