fixup to async_prompt_enable flag - #89
Open
ilyagr wants to merge 2 commits into
Open
Conversation
ilyagr
force-pushed
the
fixup-disabling-async
branch
6 times, most recently
from
June 7, 2025 05:37
e3a4dda to
67d259c
Compare
316aa03 did not disable fish-async-prompt sufficiently for me when I used ```fish if test "$TERM_PROGRAM" = vscode set -g async_prompt_enable 0 end ``` fish-async-prompt still interfered with the VS Code Terminal, but adding this seemed to fix it.
ilyagr
force-pushed
the
fixup-disabling-async
branch
from
June 8, 2025 00:37
67d259c to
79cb9c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
316aa03 did not disable fish-async-prompt sufficiently for me when I used
fish-async-prompt still interfered with the VS Code Terminal.
This PR together with the above snippet seemed sufficient to disable fish-async-prompt to a degree that worked around the VS Code problem (see microsoft/vscode#250916 for more details about the VS Code problem).
Warning: Note that, like before, this will only work correctly if
async_prompt_enableis set to 0 before the first prompt is drawn.I'd love to remove this limitation, but that would require understanding how to recover the old
fish_prompt. Update: Something like this might actually be enabled by #86, but that PR is complicated enough that I don't want to rely on it without thinking about it quite a bit more.