Parameterize script tunables and example properties files#2
Open
djones6 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AcmeAir.jmxscript has a number of tunables which are currently hard-coded. This PR converts those to parameters with default values. The effect is that you can do this:jmeter -t AcmeAir.jmx -JTHREADS=10 -JDURATION=60 -JHOSTNAME=myserver -JPORT=9080 -JCONTEXT_ROOT=/I've provided example user.properties and system.properties files which can be passed to JMeter as follows:
-q user.properties -S system.properties. These can be used instead of or in combination with the command-line overrides.The user.properties contains the same default values as the original AcmeAir.jmx script. Users could make multiple variants of user.properties for testing different backends or load levels.
The system.properties provides another method to set the
usePureIDsproperty required for Node.js. Arguably there's no benefit to specifying the system properties file instead of the property itself, but it provides a point to add further customization.Overall this means that it is no longer necessary to modify the AcmeAir.jmx script or jmeter.properties.