Change date format to make it parsable by javascript.#1
Open
axel7born wants to merge 1 commit into
Open
Conversation
|
Sent email to Moss Uchida asking if the referenced PR is going to land. |
|
@aspyker any chance this will land ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running acmeair-nodejs I had the problem, that the the date genretated by __generateDate() can't be parsed by the javascript Date() constructor resulting in an undefined object.
Running with mongodb the acmeair app doesn't complain about that. It simpy doesn't find any flights. Running with cassandra, the app procuces error messages.
I changed the format in a way, that the string can be used in the Date constructor.
I only tested with acmeair-nodejs. I can't say, if it is still working with the java implementaion.