refactor(llm-access): extract provider.rs tests into provider/tests.rs (PR-A) by acking-you · Pull Request #19 · acking-you/static_flow

acking-you · 2026-05-31T18:29:55Z

What

First of two PRs splitting the 14326-line llm-access/src/provider.rs — the largest file in the llm-access* refactor sequence and the only one in the production binary crate. This PR-A is the mechanical, near-zero-risk half: move the single mod tests block (106 tests, ~7000 lines) into provider/tests.rs via #[cfg(test)] mod tests;.

provider.rs: 14326 → 7301 lines. PR-B will then domain-split the remaining ~7300 lines of code into concern submodules (free-fn DAG shape, like the duckdb split #16).

Why this is safe

The test code was already a separate mod tests accessing parents via super::, so relocating it to a file changes nothing about name resolution.
provider.rs is already a mod.rs-style facade (it declares mod kiro_error; mod kiro_session_affinity; with a provider/ dir present), so adding a submodule file is the established local convention.
The #[cfg(test)] + #[allow(clippy::await_holding_lock, reason=…)] attributes ride on the mod tests; decl (outer attrs apply to the file's contents).

Behavior-preserving — and a note on how

Extracted the body verbatim (no hand-dedent) and let rustfmt normalize it. This matters: a naive dedent-by-4 would shift the interiors of multi-line raw-string literals (e.g. the format!(r#"{{…}}"#) JSON templates) — JSON-benign but a real byte change to test data. Verbatim→rustfmt leaves raw-string interiors byte-for-byte identical to master (rustfmt reindents code, never literal contents) while collapsing the now-fits-in-100-cols wraps at the shallower indent.

Verified:

identical fn-name set vs pre-split, same 106 test attrs
format! JSON-template interiors confirmed unchanged (16-space indent, as on master)
rustfmt-idempotent (2nd pass is a no-op)

Verification

cargo clippy -p llm-access --all-targets -- -D warnings → clean
cargo test -p llm-access provider:: → 111 passed
rustfmt on the 2 changed files only; deps/lance/deps/lancedb untouched

🤖 Generated with Claude Code

First of two PRs splitting the 14.3k-line provider.rs (the largest file in the sequence). This PR-A is the mechanical, near-zero-risk half: move the single `mod tests` block (106 tests, ~7000 lines) into `provider/tests.rs` via `#[cfg(test)] mod tests;`. PR-B will domain-split the remaining ~7300 lines of code into submodules. `provider.rs`: 14326 -> 7301 lines. The module was already a separate `mod tests` accessing parents via `super::`, so moving it to a file changes nothing about name resolution. The `#[cfg(test)]` + `#[allow(clippy::await_holding_lock, reason=...)]` attributes ride on the `mod tests;` decl (outer attrs apply to the file's contents). Behavior-preserving: extracted the body verbatim (no hand-dedent) and let rustfmt normalize it, so raw-string literal interiors (e.g. the `format!` JSON templates) stay byte-for-byte identical to master rather than being shifted by a manual dedent. Verified: identical fn-name set vs pre-split, same 106 test attrs, rustfmt-idempotent. Verification: - cargo clippy -p llm-access --all-targets -- -D warnings -> clean - cargo test -p llm-access provider:: -> 111 passed - rustfmt on the 2 changed files only; deps/lance, deps/lancedb untouched Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

gemini-code-assist · 2026-05-31T18:29:59Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

acking-you · 2026-05-31T18:30:09Z

/gemini review

acking-you · 2026-05-31T18:30:10Z

@codex review

gemini-code-assist · 2026-05-31T18:30:13Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

chatgpt-codex-connector · 2026-05-31T18:31:53Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

#20) Second of two PRs splitting the 14.3k-line provider.rs (PR-A #19 extracted the 106 tests; this PR-B domain-splits the remaining ~7300 code lines). Free-fn DAG shape (like the duckdb split), already mod.rs-style. provider.rs: 7301 -> 603 lines. 182 free fns + 16 impls (63 methods) move into 19 concern submodules: usage_meta, state, limiter, route_selection, codex_dispatch, kiro_media, kiro_dispatch, stream_guards, kiro_protocol, client, errors, kiro_model, kiro_usage, entry, codex_auth, codex_sse, kiro_summary, util, codex_models. Behavior-preserving structural move: identical top-level name multiset (336), same 106 tests. Fat facade keeps all 47 types + 2 traits + 24 consts/statics (submodules read private fields as ancestor-privates, no field-vis change). Moved free fns -> pub only where cross-region referenced (102/182); inherent methods -> pub(super) only where a foreign region calls them (25/46); trait-impl methods never bumped. Facade re-imports in 3 categories: external API preserved via pub/pub(crate) use (provider_entry*, codex_upstream_base_url, compute_codex_upstream_url, resolve_codex_client_version, codex_public_model_catalog_response, default_codex_public_model_catalog_response, call_kiro_generate_for_route, decode_kiro_events_from_bytes); unconditional `use` for fns the facade's LazyLock statics call (build_provider_client + client-pool tunables); and `#[cfg(test)] use` for fns/types tests reach via super:: (incl. axum Method). Named the kiro-header module `kiro_protocol` to avoid colliding with the `use crate::kiro_headers` binding (E0255). Pre-existing kiro_error.rs calls super::{anthropic_json_error, summarize_error_bytes} -> facade re-imports them so those super:: paths still resolve. Verification: - cargo clippy -p llm-access --all-targets -- -D warnings -> clean - cargo test -p llm-access provider:: -> 111 passed - rustfmt on the 20 changed files only; deps/lance, deps/lancedb untouched Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

acking-you merged commit fdf0876 into master May 31, 2026
3 checks passed

acking-you mentioned this pull request May 31, 2026

refactor(llm-access): domain-split provider.rs into concern submodules (PR-B) #20

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(llm-access): extract provider.rs tests into provider/tests.rs (PR-A)#19

refactor(llm-access): extract provider.rs tests into provider/tests.rs (PR-A)#19
acking-you merged 1 commit into
masterfrom
refactor/split-llm-access-provider

acking-you commented May 31, 2026

Uh oh!

gemini-code-assist Bot commented May 31, 2026

Uh oh!

acking-you commented May 31, 2026

Uh oh!

acking-you commented May 31, 2026

Uh oh!

gemini-code-assist Bot commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

acking-you commented May 31, 2026

What

Why this is safe

Behavior-preserving — and a note on how

Verification

Uh oh!

gemini-code-assist Bot commented May 31, 2026

Uh oh!

acking-you commented May 31, 2026

Uh oh!

acking-you commented May 31, 2026

Uh oh!

gemini-code-assist Bot commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant