Skip to content

VD-3016: add repo and CI guardrails (providers)#6

Merged
hbanerjee74 merged 1 commit into
mainfrom
feature/vd-3016-repo-ci-guardrails
Jul 4, 2026
Merged

VD-3016: add repo and CI guardrails (providers)#6
hbanerjee74 merged 1 commit into
mainfrom
feature/vd-3016-repo-ci-guardrails

Conversation

@arpit-acceleratedata

Copy link
Copy Markdown

Part of VD-3016 (with accelerate-data/obot#22 — the issue closes when both merge).

Adds the repo/CI guardrails that make this fork's images reliable Studio release inputs. The main-branch-protection ruleset is already applied live (required checks go-test / docker-build, PR + 1 approval, no force-push/deletion); this PR lands the workflow the docker-build check name comes from, and is itself the proof both checks report and pass.

Changes

  • New docker-build-check.yml — PR-time amd64 build of both Dockerfile targets (providers, encryption-bins), no push. This is the repo's real build contract: go-test alone never exercises the Dockerfile, so a broken image build previously surfaced only on the main publish run.
  • test.yamlready_for_review trigger (upstream-sync drafts are created with GITHUB_TOKEN, whose events start no workflows; without this, required checks never report on sync PRs and they can never merge) and setup-go v4 → v5 (deprecated runner, flagged by actionlint).
  • .github/rulesets/main-branch.json — the applied ruleset, versioned in-repo.
  • New AGENTS.md — CI gates, fail-closed publish contract, failure ownership, local verification commands.

Verification

  • actionlint clean on both workflows
  • Ruleset JSON validated against a live org ruleset shape and applied successfully (id 18491862)
  • Publish workflow confirmed fail-closed as-is (untagged digest pushes → manifest merge → arch verification → cosign); not modified
  • Adversarial subagent review of the diff; its one confirmed finding (sync-PR merge deadlock) is fixed by the ready_for_review trigger

🤖 Generated with Claude Code

- docker-build-check.yml: PR-time amd64 build of both Dockerfile
  targets, no push — the repo's real build contract; go-test alone
  never exercises the Dockerfile
- test.yaml, docker-build-check.yml: ready_for_review trigger so
  required checks report on upstream-sync drafts made with GITHUB_TOKEN,
  whose events start no workflows; setup-go v4 -> v5 (deprecated runner)
- .github/rulesets/main-branch.json: versioned ruleset (PR + 1 approval,
  required checks go-test/docker-build, no force-push or deletion)
- AGENTS.md: CI gates, fail-closed publish contract, local verification

Part of VD-3016

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jul 4, 2026

Copy link
Copy Markdown

VD-3016

@hbanerjee74 hbanerjee74 merged commit 0671c62 into main Jul 4, 2026
3 checks passed
@hbanerjee74 hbanerjee74 deleted the feature/vd-3016-repo-ci-guardrails branch July 4, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants