Fix MCP instance OAuth redirects#21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Studio's real-Obot MCP setup flow creates per-user MCP server instances and then drives downstream OAuth through Obot. The route exists and the browser journey reaches it, but the OAuth redirect request is denied unless the authz resource map recognizes
/api/mcp-server-instances/{id}/oauth-redirectas an owned MCP server instance action.Validation
go test ./pkg/api/authz -count=1OBOT_IMAGE=obot-vibedata:local-test npx playwright test --config config/playwright/playwright.backed.config.ts tests/e2e/journeys/backed/mcp-real-obot-backed.journey.spec.ts -g 'drives setup, OAuth, unsupported, and disconnect paths against real Obot'Release note
After this merges, the
Build and Push obot-vibedataworkflow should publish a newghcr.io/accelerate-data/obot-vibedata:latestdigest. Studio then needs to runnpm run obot:image:bumpand rerun the Obot-focused gates against the new pinned digest.