Add conversation views to 12 SMS/chat artifacts (Tier 1 + safe Tier 2)#925
Merged
Conversation
Wire the LAVA conversation data_view onto existing columns for: SMS Messages (native mmssms.db), MeWe - Chat, Skype - Messages, Line - Messages, Viber - Messages, Bumble - Chat Messages, kleinanzeigen.de - Messages, Burner - Communications, and Life360 - Chat Messages. Every directionSentValue was verified against the value each query actually produces (e.g. SMS 'Sent' from the type CASE, Life360 'Yes' from message.sent, 'Outgoing' for the rest). Artifacts without a sender column use the sentMessageStaticLabel 'Local User' pattern. Metadata-only; no parsing or schema changes. last_update_date bumped on the touched artifacts.
- MMS Messages: select pdu.msg_box and emit a Direction column mapped via the documented Telephony.Mms constants (1 Received / 2 Sent / 3 Draft / 4 Outbox), wording mirroring the SMS type CASE; conversation view with the Media column wired as mediaColumn. - SMS and MMS Backup: map the backup XML's raw Telephony.Sms type into a Direction column (raw Type retained for fidelity); views for both SMS (thread=Address) and MMS (thread=Recipients, direction=mapped Message Box which already emits 'Sent').
abrignoni
changed the title
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the LAVA threaded
conversationdata_view to the 9 chat artifacts whose existing columns already support it (metadata-only diffs, no parsing/schema changes):Sent(from type CASE)SentOutgoingOutgoingOutgoingOutgoingOutgoingOutgoingYes(frommessage.sent)Every
directionSentValuewas verified against the literal value each query produces — not assumed from the header name. Artifacts with no sender column usesentMessageStaticLabel: 'Local User'(same pattern as burnerMessages #923).Deliberately deferred (need query/header work, not just metadata)
key_remote_jid(the chat JID); fixing that mislabel should come with the viewType), textnow (thread col in SQL but not in headers), googleVoice messages, imo (no single thread column), RandoChat (unverified direction values), meetme/blueskymessages/wireMessenger/kijiji (no direction column)Testing
--disable=C,Ron all 9 files → 10.00/10data_headers— all validmediaColumnintentionally omitted this pass; can follow once media-typed columns are confirmed per artifact