LinkedIn: migrate legacy 'chat' data_view key to 'conversation'#924
Merged
Conversation
The block already used the conversation-form column names; only the view key was legacy. Last in-repo user of the lavafuncs chat shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line key rename: LinkedIn's data_view already used the conversation-form column names (
conversationDiscriminatorColumn/conversationLabelColumn) — only thechatview key was legacy. This was the last in-repo user of the backward-compat shim inlavafuncs.py; every ALEAPP data_view is nowconversation(verified via PluginLoader), so the shim can be retired in a future framework pass.Testing: pylint 10.00/10, byte-compile clean, PluginLoader registers the converted view.