Context-form retrofit (batch 8): Cello, chatgpt#913
Merged
Conversation
Batch 8 (10 functions / 2 files). 4-arg -> def fn(context); the path column / source_path returns now use context.get_relative_path(). - Cello: 'Source File' column + file source_path. - chatgpt: all 9 functions; get_chatgpt_media has the 'Location' column, the other 8 return a full source_path (db/pb file) now relativized. All context form; pylint 10.00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 8 (10 functions / 2 files). Same pattern: 4-arg →
def fn(context),context.get_relative_path()on the path column / source-path return.Source Filecolumn + file source.get_chatgpt_mediahas theLocationcolumn, the other 8 return a fullsource_path(db/pb file) now relativized.pylint 10.00, all context form, imports clean, 12
get_relative_pathapplications. 26 of 28 done — DuckDuckGo + OrnetBrowser are the last two (their own batches).