Fix emacs native compilation warnings#230
Closed
cody-vibe wants to merge 1 commit into
Closed
Conversation
To reproduce, have emacs built with native compilation and notice the
compilation logs. You can then open the offending file and run `M-x
emacs-lisp-native-compile-and-load` before and after the changes to see
the warning is removed.
```
ace-window.el:95:2: Warning: custom-declare-variable `aw-minibuffer-flag'
docstring wider than 80 characters
ace-window.el:99:2: Warning: custom-declare-variable `aw-ignored-buffers'
docstring wider than 80 characters
ace-window.el:104:2: Warning: custom-declare-variable `aw-ignore-on' docstring
wider than 80 characters
ace-window.el:117:12: Warning: defcustom for ‘aw-leading-char-style’ has
syntactically odd type ‘'(choice (const :tag single char 'char) (const
:tag full path 'path))’
ace-window.el:138:2: Warning: custom-declare-variable `aw-frame-offset'
docstring wider than 80 characters
ace-window.el:143:2: Warning: custom-declare-variable `aw-frame-size'
docstring wider than 80 characters
ace-window.el:149:12: Warning: defcustom for ‘aw-char-position’ has
syntactically odd type ‘'(choice (const :tag top left corner only
'top-left) (const :tag both left corners 'left))’
ace-window.el:157:2: Warning: defvar `aw-dispatch-alist' docstring wider than
80 characters
ace-window.el:191:2: Warning: custom-declare-variable `aw-make-frame-char'
docstring wider than 80 characters
ace-window.el:449:2: Warning: docstring wider than 80 characters
```
|
Please merge #221, then this PR. |
Author
|
Sorry but I'm no longer interested in pursuing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce, have emacs built with native compilation and notice the compilation logs. You can then open the offending file and run
M-x emacs-lisp-native-compile-and-loadbefore and after the changes to see the warning is removed.