Skip to content

Release 1.2.58 - #2192

Merged
AndyTWF merged 2 commits into
mainfrom
release-1.2.58
Feb 25, 2026
Merged

Release 1.2.58#2192
AndyTWF merged 2 commits into
mainfrom
release-1.2.58

Conversation

@AndyTWF

@AndyTWF AndyTWF commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump version to 1.2.58
  • Update change log

Changes in this release

Full Changelog: 1.2.57...1.2.58

Summary by CodeRabbit

  • New Features

    • Added agent information capabilities including platform, library, and device details.
    • Added support for decoding and encoding extras on presence messages.
  • Chores

    • Version bumped to 1.2.58.
    • Updated documentation and configuration files to reflect the latest version.

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown

Walkthrough

This is a version bump release from 1.2.57 to 1.2.58 that updates version numbers across configuration files, documentation, and tests. The release introduces new public methods in ARTClientInformation for constructing and managing platform and library agent identifiers.

Changes

Cohort / File(s) Summary
Version Bump & Configuration
CHANGELOG.md, README.md, Scripts/jazzy.sh, Version.xcconfig
Updated version references from 1.2.57 to 1.2.58 across documentation and build configuration files.
Client Information Agent Methods
Source/ARTClientInformation.m
Bumped library version to 1.2.58 and added 10 new public methods for agent management: agents, agentIdentifierWithAdditionalAgents, agentIdentifierForAgents, libraryAgent, libraryAgentIdentifier, platformAgent, platformAgentIdentifier, osName, osVersionString, and deviceModel. Methods support merging additional agents, OS-specific versioning, and device model retrieval.
Test Expectations
Test/AblyTests/Tests/ARTDefaultTests.swift, Test/AblyTests/Tests/ClientInformationTests.swift, Test/AblyTests/Tests/RealtimeClientConnectionTests.swift, Test/AblyTests/Tests/RestClientTests.swift, Test/AblyTests/Tests/WrapperSDKProxyTests.swift
Updated test assertions to expect version 1.2.58 instead of 1.2.57 in library version checks and Ably-Agent header validations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • umair-ably
  • maratal

Poem

🐰 A version hops from 57 to 58,
With agent methods that now coordinate,
Platform and library, mixed with care,
The tests all pass, the version's fair! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Release 1.2.58' directly and clearly summarizes the main purpose of the changeset, which is to release version 1.2.58 with version bumps across all relevant files and updated changelog entries.
Docstring Coverage ✅ Passed Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-1.2.58

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Source/ARTClientInformation.m (1)

41-49: ⚠️ Potential issue | 🟠 Major

Use string equality instead of pointer identity comparison for the sentinel.

The version == ARTClientInformationAgentNotVersioned check relies on pointer identity, which is fragile when the value flows through Swift-Objective-C bridging. Use isEqualToString: to ensure reliable comparison regardless of how the NSString instance originates.

Proposed fix
-        if (version == ARTClientInformationAgentNotVersioned) {
+        if ([version isEqualToString:ARTClientInformationAgentNotVersioned]) {
             [components addObject:name];
         } else {
             [components addObject:[NSString stringWithFormat:@"%@/%@", name, version]];
         }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Source/ARTClientInformation.m` around lines 41 - 49, The code currently
compares NSString instances by pointer identity; change the sentinel check in
the agent-string building loop to use string equality: replace the `version ==
ARTClientInformationAgentNotVersioned` comparison with an `isEqualToString:`
call (i.e., test `[version
isEqualToString:ARTClientInformationAgentNotVersioned]`) when constructing
components in the loop that iterates over `sortedAgentNames` and uses `version`
and `ARTClientInformationAgentNotVersioned`.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@Source/ARTClientInformation.m`:
- Around line 41-49: The code currently compares NSString instances by pointer
identity; change the sentinel check in the agent-string building loop to use
string equality: replace the `version == ARTClientInformationAgentNotVersioned`
comparison with an `isEqualToString:` call (i.e., test `[version
isEqualToString:ARTClientInformationAgentNotVersioned]`) when constructing
components in the loop that iterates over `sortedAgentNames` and uses `version`
and `ARTClientInformationAgentNotVersioned`.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4bd83ea and 9b04154.

📒 Files selected for processing (10)
  • CHANGELOG.md
  • README.md
  • Scripts/jazzy.sh
  • Source/ARTClientInformation.m
  • Test/AblyTests/Tests/ARTDefaultTests.swift
  • Test/AblyTests/Tests/ClientInformationTests.swift
  • Test/AblyTests/Tests/RealtimeClientConnectionTests.swift
  • Test/AblyTests/Tests/RestClientTests.swift
  • Test/AblyTests/Tests/WrapperSDKProxyTests.swift
  • Version.xcconfig

@AndyTWF
AndyTWF enabled auto-merge February 25, 2026 13:24
@AndyTWF
AndyTWF merged commit 14d2661 into main Feb 25, 2026
12 of 13 checks passed
@AndyTWF
AndyTWF deleted the release-1.2.58 branch February 25, 2026 13:57
@coderabbitai coderabbitai Bot mentioned this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants