Add userClaim field to all chat event types - #478
Draft
AndyTWF wants to merge 6 commits into
Draft
Conversation
Implements the userClaim feature from the chat SDK specification (CHA-M2h, CHA-ER2a, CHA-PR6g, CHA-T13a1, CHA-MR7d). This adds an optional server-provided userClaim string (extracted from JWT extras) to Message, RoomReaction, PresenceMember, TypingSetEvent.Change, and MessageReactionRawEvent.Reaction. For typing indicators, the userClaim is cached per-client and persisted across heartbeat events. The timer expiry handler signature was updated to pass the cached userClaim as a parameter, since state is cleared before the handler runs. Includes 26 new unit tests and integration test assertions verifying userClaim is nil under standard API key auth. [CHA-1243] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
temporarily deployed
to
staging/pull/478/AblyChat
February 12, 2026 16:04
Inactive
… 1.2.58 - Bump ably-cocoa dependency from 1.2.51 to 1.2.58 for userClaim support - Add TypingMember struct pairing clientID with userClaim metadata - Add currentTypers property to Typing protocol and TypingSetEvent - Add currentlyTypingMembers() to TypingTimerManager - Consolidate createSandboxChatClient/createSandboxChatClientWithJWT into a single helper with optional JWT parameters - Add JWT auth helper (Sandbox.createJWT) for integration tests - Add integration test for userClaim propagation across all event types - Stub new ARTChannelProtocol methods from ably-cocoa 1.2.58 in mock Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
temporarily deployed
to
staging/pull/478/AblyChat
February 25, 2026 16:58
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/478/AblyChat
February 26, 2026 14:54
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/478/AblyChat
February 26, 2026 16:54
Inactive
github-actions
Bot
temporarily deployed
to
staging/pull/478/AblyChat
February 26, 2026 17:16
Inactive
…ion, fix formatting - Add missing `currentTypers` property to `MockTyping` for `Typing` protocol conformance - Add `currentTypers` parameter to all `TypingSetEvent` initializer calls in MockTyping - Handle new `.append` case in `ARTMessageAction` switch in Events.swift - Fix Prettier formatting in CHA-1243-user-claims.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
temporarily deployed
to
staging/pull/478/AblyChat
February 26, 2026 17:24
Inactive
- Sync xcworkspace Package.resolved with root (was stale at ably-cocoa 1.2.51) - Change @specPartial to @SPEC for CHA-M2h to resolve conflicting tag types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Per CHA-T13a1, when a heartbeat arrives without a userClaim, the stored value must be cleared (not preserved). This matches the JS SDK behavior where the internal state is always overwritten with the incoming event's claim value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
userClaim: String?property toMessage,RoomReaction,PresenceMember,TypingSetEvent.Change, andMessageReactionRawEvent.ReactionTest plan
UserClaimTests.swiftcovering extraction, all five event types, and typing timer edge casesuserClaimisnilunder standard API key auth (no JWT claims)TypingTimerManagerTestsupdated for new handler signature — all 232 tests passCHA-1243
🤖 Generated with Claude Code