fix: use request-first TemplateResponse signature on index route - #5
Open
SAY-5 wants to merge 1 commit into
Open
fix: use request-first TemplateResponse signature on index route#5SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index route calls
templates.TemplateResponse("index.html", {"request": request}), which uses Starlette's legacy argument order. That form has been deprecated for a while and now raisesTypeError: unhashable type: 'dict'on Starlette 1.0, since the template name ends up being the context dict. That is the 500 seen in #4 when opening the page.Switched to the request-first form Starlette recommends,
TemplateResponse(request, "index.html"), and added a small regression test that fails if the deprecated order comes back. Full test suite and black/isort/flake8 stay green.Fixes #4