submit: export CheckStaleBases for external callers#1177
Closed
ed-irl wants to merge 2 commits into
Closed
Conversation
Add cycle detection to survivingAncestor so that if deleted branches form a cycle in their base references, the function falls back to trunk instead of looping forever.
Add public StaleBase type and CheckStaleBases function that wraps the existing internal staleBaseCandidates discovery and forge-query logic. Used by external commands (branch merge in the immediately stacked PR) that need to perform the same pre-flight check submit does, without duplicating the candidate-discovery logic. The internal API used by submit itself is unchanged; this only adds new exports.
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
abhinav
force-pushed
the
sync-survivingancestor-loop
branch
2 times, most recently
from
e4b5f2e to
ddbdacb
Compare
Owner
|
Superseded by #1211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add public StaleBase type and CheckStaleBases function that wraps the
existing internal staleBaseCandidates discovery and forge-query logic.
Used by external commands (branch merge in the immediately stacked PR)
that need to perform the same pre-flight check submit does, without
duplicating the candidate-discovery logic.
The internal API used by submit itself is unchanged; this only adds new
exports.