Fix sign handling when converting hex offsets to integer - #1776
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix bug in converting hex to int
Fix sign handling when converting hex offsets to integer
Jul 30, 2026
|
Regression test results:
Performance test results:
Updated: 2026-07-30T11:23:42.218Z SHA: ce2e5e0 |
larshp
approved these changes
Jul 30, 2026
larshp
marked this pull request as ready for review
July 30, 2026 11:28
larshp
enabled auto-merge (squash)
July 30, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting a hex value to
ionly applied two's complement when the source was aHex/HexUInt8field of length >= 4. Offsetting a hex field returns anXString, so the sign bit was ignored:Changes
packages/runtime/src/types/integer.ts:set()now derives the byte length from the hex string itself instead ofgetLength(), soHex,HexUInt8andXStringare treated uniformly. Values of 4 bytes or more are interpreted as two's complement; shorter values (e.g.lv_hex+1(2)→65535) remain unsigned.test/types/integer.ts: cases forx LENGTH 4='FFFFFFFF', the offset case above, and a 2-byte offset that must stay positive.Note that
Hex.getOffset()returningXStringdiscards the original length, which is why the type-based check was insufficient.