Fix INSERT INITIAL LINE into hashed tables - #1774
Merged
Merged
Conversation
Closed
Copilot
AI
changed the title
[WIP] Fix bug with INSERT INITIAL in hashed table
Fix INSERT INITIAL LINE into hashed tables
Jul 30, 2026
|
Regression test results:
Performance test results:
Updated: 2026-07-30T11:23:48.308Z SHA: b1a7fe5 |
larshp
marked this pull request as ready for review
July 30, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSERT INITIAL LINE INTO TABLEthrewError: Hash table insert indexwhen the target was a hashed table:The
initialbranch ofinsertInternalunconditionally calledinsertIndex, whichHashedTabledoes not implement.Changes
packages/runtime/src/statements/insert_internal.ts: theinitialbranch now routesHashedTablethroughinsert()with the table's row type, settingsy-subrcfrom the result (4 on duplicate key) and assigningASSIGNING/REFERENCE INTOtargets only on success.test/statements/insert.ts: test covering the issue snippet, including a second insert of the same initial line yieldingsy-subrc = 4and no added row.