Allows zeta specification when rendering to a non-framebuffer surface.#8
Merged
Conversation
abaire
force-pushed
the
render_to_surface_improvements
branch
from
b8cdd0d to
c5afe61
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements support for rendering to surfaces with custom zeta (depth/stencil) buffers, adding a new RenderToSurfaceStart overload and updating RenderToSurfaceEnd to restore the zeta state. Feedback focuses on ensuring the zeta format is correctly backed up in all RenderToSurfaceStart overloads to prevent incorrect state restoration. Additionally, a return statement is needed in the default case of GetSurfaceZetaPitch to prevent potential undefined behavior.
abaire
force-pushed
the
render_to_surface_improvements
branch
from
c5afe61 to
5ea67af
Compare
abaire
force-pushed
the
render_to_surface_improvements
branch
from
5ea67af to
e82294e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.