Skip to content

feature: add get method with limit parameter to FileDictionaryStorage #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minjae999 merged 1 commit into from
Feb 11, 2026
Merged

feature: add get method with limit parameter to FileDictionaryStorage #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Source/AppleStorage/DictionaryStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ public protocol DictionaryStorage<Key, Value>: Storage {
func delete(key: Key) -> Promise<Void, Error>
func clear() -> Promise<Void, Error>
func get(key: Key) -> Promise<Value?, Error>
func get(limit: Limit) -> Promise<[Value], Error>
func save() -> Promise<Void, Error>
}
16 changes: 16 additions & 0 deletions Source/AppleStorage/Implement/FileDictionaryStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,21 @@ extension FileDictionaryStorage {
}
}
}

public func get(limit: Limit) -> Promise<[Value], Error> {
execute { context in
context.values.capture { values in
let array = Array(values.values)
switch limit {
case .unlimited:
return array
case .count(let limit):
return Array(array.prefix(limit))
}
}
}
}


public func save() -> Promise<Void, Error> {
execute { context in
Expand Down Expand Up @@ -167,3 +182,4 @@ struct FileDictionaryStorageContext<Key: Hashable & Codable, Value: Codable> {

// Must not be modified. Write new ItemVersion and write migration logic instead.
typealias FileDictionaryStorageItemVersion1<Key: Hashable & Codable, Value: Codable> = [Key: Value]