fix: landing CTA showed 'pip install spiritwriter-core'#16
Merged
Conversation
The second copy-install button's visible label still read the old package name while the clipboard action and the first button already used `spiritwriter`. Distribution is `spiritwriter`; the repo stays `spiritwriter-core`. This is the "core" CTA visible live on the home page. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The home page's second copy-install button displayed
pip install spiritwriter-core— the stale "core" CTA visible live onnews.spiritwriter.ai(footer commit3636876). This was the one spot the package rename missed:landing.html:1079):pip install spiritwriter✅ (already correct)landing.html:1348):pip install spiritwriter-core❌ → fixedlanding.html:1415): copiespip install spiritwriter✅ (already correct)So the button copied the right command but showed the wrong one.
Why it looked like a stale deploy
It wasn't — the deployment was current with
main. The latest code itself still carried this visible label. The distribution name isspiritwriter(the GitHub repo staysspiritwriter-core), so only the install-command text needed to change.Change
One line: the visible label on the closing-CTA copy button →
pip install spiritwriter. No otherspiritwriter-corestrings remain inlanding.htmloutside the legitimate GitHub repo URLs.Merging this to
maintriggers the deploy workflow, which re-renders the site.🤖 Generated with Claude Code