Skip to content

Update from upstream #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aakvatech wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update from upstream #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83fe2b9
Merge pull request #1 from Totrox/role-permissions
yrestom Nov 18, 2021
7520507
chore: optimize code
yrestom Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions permission/permission/doctype/permission_assignment/permission_assignment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@ def validate_role(self):
_("This User can't have more than one Permission Assignment")
)

permissions_dict = {}
for row in policy.role_permission_profile_detail:
permissions_dict.setdefault(row.doctype_name, [])
if row.docname not in permissions_dict[row.doctype_name]:
permissions_dict[row.doctype_name].append(row.docname)

for perm in self.role_permission_profile_detail:
doc = frappe.get_doc(perm.doctype_name, perm.docname)
permissions_dict = {}
for row in policy.role_permission_profile_detail:
permissions_dict.setdefault(row.doctype_name, [])
if row.docname not in permissions_dict[row.doctype_name]:
permissions_dict[row.doctype_name].append(row.docname)
for key, value in permissions_dict.items():
fields = doc.meta.get(
"fields", {"fieldtype": "Link", "options": key}
Expand Down