Open
Conversation
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: improvement
User Impact: Text selection in goose2 now feels calmer and less visually jarring while preserving copyable chat and input text.
Problem: The global selection treatment used a strong brand fill with inverse text, which made selected text feel loud and heavy. App chrome could also be selected in places where selection is not useful, making accidental drag or right-click interactions feel messy.
Solution: Switch global selection to a low-opacity neutral tint that keeps the original text color, remove the input override that forced inverse selection colors, and make button/drag-region chrome non-selectable. Inputs, textareas, contenteditable content, and Streamdown-rendered chat content remain selectable.
File changes
ui/goose2/src/shared/styles/globals.css
Softens
::selectionglobally and scopesuser-selectso chrome is not selectable while text-entry and chat markdown surfaces remain selectable.ui/goose2/src/shared/ui/input.tsx
Removes the input-specific primary/inverse selection classes so fields use the calmer global selection treatment.
Focused verification
pnpm --dir ui/goose2 exec biome check src/shared/styles/globals.css src/shared/ui/input.tsxgit diff --checkrg -n "selection:bg-primary|selection:text-primary-foreground|::selection" ui/goose2/src ui/goose2 -g '*.css' -g '*.tsx' -g '*.ts'Full goose2 pre-push/typecheck remains blocked by existing unrelated SDK definition mismatches on
mainsuch as missingGoosePreferencesRead,GooseDefaultsRead, andProviderConfigChangeResponseexports.Screenshots/Demos
Not captured in this pass.