Skip to content

Revert "feat: complete SIGNAL frontend dashboard"#23

Merged
aadityad12 merged 1 commit into
mainfrom
revert-22-feat/frontend-all-issues
May 10, 2026
Merged

Revert "feat: complete SIGNAL frontend dashboard"#23
aadityad12 merged 1 commit into
mainfrom
revert-22-feat/frontend-all-issues

Conversation

@aadityad12

Copy link
Copy Markdown
Owner

Reverts #22

@aadityad12 aadityad12 merged commit 689610a into main May 10, 2026
1 check failed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51520de1d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -1,27 +0,0 @@
{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the frontend manifest

The repo still documents the demo startup as cd signal/frontend && npm install && npm run dev in CLAUDE.md and TEAM_START_HERE.md, but this deletion removes the frontend package manifest along with the app, so that documented path now fails before Vite can start. If the dashboard is still part of the hackathon demo, keep the frontend files or update the demo/startup flow everywhere so it no longer depends on signal/frontend.

Useful? React with 👍 / 👎.

Comment thread .gitignore
node_modules/
dist/
.env.local
__pycache__/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep local Vite env files ignored

Removing .env.local from the ignore list makes developer-local frontend overrides trackable again; Vite projects commonly use .env.local for machine-specific URLs or secrets, and this repo’s frontend setup already relies on env files for WebSocket configuration. If a teammate recreates or runs the frontend with local overrides, those values can now be accidentally committed, so this ignore entry should stay even if the tracked frontend .env is removed.

Useful? React with 👍 / 👎.

Comment thread .gitignore
.env.local
__pycache__/
*.pyc
*.pyo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep local Vite env files ignored

Removing .env.local from the ignore list makes developer-local frontend overrides trackable again; Vite projects commonly use .env.local for machine-specific URLs or secrets, and this repo’s frontend setup already relies on env files for WebSocket configuration. If a teammate recreates or runs the frontend with local overrides, those values can now be accidentally committed, so this ignore entry should stay even if the tracked frontend .env is removed.

Useful? React with 👍 / 👎.

Comment thread .gitignore
Comment on lines 1 to 2
__pycache__/
*.pyc

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep npm outputs out of git

The setup docs still instruct teammates to run npm install and npm run dev from signal/frontend; after deleting the node_modules/ and dist/ ignore rules, the next local install or Vite build can be swept into git add . as thousands of dependency or generated files. Keep these ignore patterns unless the repo is intentionally abandoning the frontend workflow everywhere.

Useful? React with 👍 / 👎.

@shahxsheel shahxsheel deleted the revert-22-feat/frontend-all-issues branch May 10, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant