Revert "feat: complete SIGNAL frontend dashboard"#23
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51520de1d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,27 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
The repo still documents the demo startup as cd signal/frontend && npm install && npm run dev in CLAUDE.md and TEAM_START_HERE.md, but this deletion removes the frontend package manifest along with the app, so that documented path now fails before Vite can start. If the dashboard is still part of the hackathon demo, keep the frontend files or update the demo/startup flow everywhere so it no longer depends on signal/frontend.
Useful? React with 👍 / 👎.
| node_modules/ | ||
| dist/ | ||
| .env.local | ||
| __pycache__/ |
There was a problem hiding this comment.
Keep local Vite env files ignored
Removing .env.local from the ignore list makes developer-local frontend overrides trackable again; Vite projects commonly use .env.local for machine-specific URLs or secrets, and this repo’s frontend setup already relies on env files for WebSocket configuration. If a teammate recreates or runs the frontend with local overrides, those values can now be accidentally committed, so this ignore entry should stay even if the tracked frontend .env is removed.
Useful? React with 👍 / 👎.
| .env.local | ||
| __pycache__/ | ||
| *.pyc | ||
| *.pyo |
There was a problem hiding this comment.
Keep local Vite env files ignored
Removing .env.local from the ignore list makes developer-local frontend overrides trackable again; Vite projects commonly use .env.local for machine-specific URLs or secrets, and this repo’s frontend setup already relies on env files for WebSocket configuration. If a teammate recreates or runs the frontend with local overrides, those values can now be accidentally committed, so this ignore entry should stay even if the tracked frontend .env is removed.
Useful? React with 👍 / 👎.
| __pycache__/ | ||
| *.pyc |
There was a problem hiding this comment.
The setup docs still instruct teammates to run npm install and npm run dev from signal/frontend; after deleting the node_modules/ and dist/ ignore rules, the next local install or Vite build can be swept into git add . as thousands of dependency or generated files. Keep these ignore patterns unless the repo is intentionally abandoning the frontend workflow everywhere.
Useful? React with 👍 / 👎.
Reverts #22