-
Notifications
You must be signed in to change notification settings - Fork 77
fix(branding): replace remaining user-facing "Roo" strings with "Zoo" #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
cf8b454
b91a0c1
3ff89a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "zoo-code": patch | ||
| --- | ||
|
|
||
| Replace remaining user-facing "Roo" brand strings with "Zoo": the missing-tool-parameter retry notice (now localized across all 18 locales), the editor tab and webview `<title>`, the diff editor label, the terminal name, the "no visible instances" output, the credit-balance and LM Studio context-length notices, and the router/cloud removal messages. Internal identifiers (provider id `roo`, `.roo*` config files, i18n key paths, attribution headers, console logs) are intentionally left unchanged. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1723,9 +1723,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike { | |
| async sayAndCreateMissingParamError(toolName: ToolName, paramName: string, relPath?: string) { | ||
| await this.say( | ||
| "error", | ||
| `Roo tried to use ${toolName}${ | ||
| relPath ? ` for '${relPath.toPosix()}'` : "" | ||
| } without value for required parameter '${paramName}'. Retrying...`, | ||
| relPath | ||
| ? t("tools:missingToolParameterWithPath", { | ||
| toolName, | ||
| relPath: relPath.toPosix(), | ||
| paramName, | ||
| }) | ||
| : t("tools:missingToolParameter", { toolName, paramName }), | ||
|
Comment on lines
+1726
to
+1732
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice - what does this render as? |
||
| ) | ||
| return formatResponse.toolError(formatResponse.missingToolParameterError(paramName)) | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -396,6 +396,33 @@ describe("Cline", () => { | |
| }) | ||
| }) | ||
|
|
||
| describe("sayAndCreateMissingParamError", () => { | ||
| it("surfaces a localized error notice and returns the missing-parameter tool error for both relPath branches", async () => { | ||
| const cline = new Task({ | ||
| provider: mockProvider, | ||
| apiConfiguration: mockApiConfig, | ||
| task: "test task", | ||
| startTask: false, | ||
| }) | ||
|
|
||
| const saySpy = vi.spyOn(cline, "say").mockResolvedValue(undefined) | ||
|
|
||
| // relPath provided -> the "...WithPath" message branch. | ||
| const withPath = await cline.sayAndCreateMissingParamError("read_file", "path", "src/foo.ts") | ||
| // relPath omitted -> the plain message branch. | ||
| const withoutPath = await cline.sayAndCreateMissingParamError("execute_command", "command") | ||
|
|
||
| // Both branches emit an "error" say with localized text. | ||
| expect(saySpy).toHaveBeenCalledTimes(2) | ||
| expect(saySpy).toHaveBeenNthCalledWith(1, "error", expect.any(String)) | ||
| expect(saySpy).toHaveBeenNthCalledWith(2, "error", expect.any(String)) | ||
|
Comment on lines
+417
to
+418
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could these also check that the resolved string actually contains the tool name or param name? If |
||
|
|
||
| // The returned tool error names the missing parameter. | ||
| expect(withPath).toContain("path") | ||
| expect(withoutPath).toContain("command") | ||
| }) | ||
| }) | ||
|
|
||
| describe("getEnvironmentDetails", () => { | ||
| describe("API conversation handling", () => { | ||
| beforeEach(() => { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1127,7 +1127,7 @@ export const webviewMessageHandler = async ( | |
| provider.postMessageToWebview({ | ||
| type: "rooCreditBalance", | ||
| requestId, | ||
| values: { error: "Roo credit balance is no longer available." }, | ||
| values: { error: "Zoo credit balance is no longer available." }, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. leave this as Roo - wonder if this should be i18n keyed though |
||
| }) | ||
| break | ||
| } | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,8 +112,8 @@ | |
| "thinking_complete_recitation": "(Thinking complete, but output was blocked due to recitation check.)" | ||
| }, | ||
| "roo": { | ||
| "authenticationRequired": "Roo provider requires cloud authentication. Please sign in to Roo Code Cloud.", | ||
| "routerRemoved": "Roo Code Router has been removed. Please select and configure a different provider." | ||
| "authenticationRequired": "Zoo provider requires cloud authentication. Please sign in to Zoo Code Cloud.", | ||
| "routerRemoved": "Zoo Code Router has been removed. Please select and configure a different provider." | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. router Removed should stay roo |
||
| }, | ||
| "openAiCodex": { | ||
| "notAuthenticated": "Not authenticated with OpenAI Codex. Please sign in using the OpenAI Codex OAuth flow.", | ||
|
|
@@ -164,7 +164,7 @@ | |
| "mode_exported": "Mode '{{mode}}' exported successfully", | ||
| "mode_imported": "Mode imported successfully", | ||
| "roo": { | ||
| "signInUnavailable": "Roo Code Cloud sign-in is currently unavailable. Configure another provider to continue." | ||
| "signInUnavailable": "Zoo Code Cloud sign-in is currently unavailable. Configure another provider to continue." | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same with this - this is an error message when trying to access roo as a provider |
||
| } | ||
| }, | ||
| "answers": { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should stay as Roo - this whole file is referencing the old Roo router, but this should probably be i18n keyed, not sure why we'd need a default message.