Adds pedersen bool library - #736
Merged
Merged
Conversation
|
zkRelay uses Zokrates and would benefit from merging this PR. |
Schaeff
approved these changes
Mar 31, 2021
Schaeff
left a comment
Schaeff
left a comment
Member
There was a problem hiding this comment.
Thanks for nudging me on this, and sorry for the delay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change for having a pedersen hashes for booleans. Need this currently and it doesn't make sense to wrap and unwrap so much. The naming was chosen to ensure backward compatibility for the u32 version. Let me know if this is needed, thinks it makes sense, also since the embedded sha256 libraries use booleans.